Migrate to Metro DI - #3608
Open
AntsyLich wants to merge 16 commits into
Open
Conversation
MajorTanya
reviewed
Jul 17, 2026
MajorTanya
reviewed
Jul 22, 2026
| val Manga.downloadedFilter: TriState | ||
| get() { | ||
| if (Injekt.get<BasePreferences>().downloadedOnly.get()) return TriState.ENABLED_IS | ||
| if (Injekt.get<Context>().appGraph.basePreferences.downloadedOnly.get()) return TriState.ENABLED_IS |
Member
There was a problem hiding this comment.
So we're not getting rid of Injekt with this? (aside from still having to provide Injekt things for extensions)
Member
Author
There was a problem hiding this comment.
It'll require more rework and the pr is already bloated as is.
|
|
||
| private val graph: AppGraph = context.metroGraph() | ||
|
|
||
| @Inject lateinit var getTracks: GetTracks |
Member
There was a problem hiding this comment.
Can't say I'm super happy about all the lateinit vars we're creating with this new approach...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.