Skip to content

Don't require --source when partial source failure leaves a single result #6165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sinan-Karakaya wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't require --source when partial source failure leaves a single result #6165

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
981e1a9
fix: Auto-proceed on single result from working sources
Sinan-Karakaya Apr 21, 2026
3014777
fix: Add prompt to proceed on partial search failure with single result
Sinan-Karakaya Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/AppInstallerCLICore/Workflows/WorkflowBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,13 @@ namespace AppInstaller::CLI::Workflow

if (!searchResult.Failures.empty())
{
if (WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::TreatSourceFailuresAsWarning))
// When the install command finds exactly one result from working sources, auto-proceed
// instead of requiring the user to specify --source.
bool singleResultOnPartialFailure =
WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::ShowSearchResultsOnPartialFailure) &&
searchResult.Matches.size() == 1;

if (WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::TreatSourceFailuresAsWarning) || singleResultOnPartialFailure)
Comment thread
Sinan-Karakaya marked this conversation as resolved.
Outdated
Comment thread
Sinan-Karakaya marked this conversation as resolved.
Outdated
{
auto warn = context.Reporter.Warn();
for (const auto& failure : searchResult.Failures)
Expand Down
Loading