Upgrade D3D12 Agility SDK to 1.618.5 - #2170
Closed
Marijn Suijten (MarijnS95) wants to merge 2 commits into
Closed
Conversation
Marijn Suijten (MarijnS95)
requested review from
a team,
Jevan Saks (jevansaks),
Mike Battista (mikebattista) and
Vineeth Thomas Alex (vineeththomasalex)
as code owners
November 26, 2025 15:08
Marijn Suijten (MarijnS95)
changed the title
Marijn Suijten (MarijnS95)
force-pushed
the
agility-1.618
branch
2 times, most recently
from
December 18, 2025 14:45
dda8a3b to
c93053b
Compare
Rafael Rivera (riverar)
previously approved these changes
Feb 10, 2026
Marijn Suijten (MarijnS95)
force-pushed
the
agility-1.618
branch
from
February 10, 2026 08:20
c93053b to
16ba526
Compare
Member
|
Sorry for the delay on this. If you can rebase to latest I'll merge this in. |
Contributor
Author
|
Thanks for the confirmation, I'll do that first thing tomorrow! |
Marijn Suijten (MarijnS95)
force-pushed
the
agility-1.618
branch
from
April 2, 2026 09:42
16ba526 to
12a5e92
Compare
Contributor
Author
|
Jevan Saks (@jevansaks) rebased now! |
Contributor
Author
|
Jevan Saks (@jevansaks) this one already passes CI, should we merge it ahead of #2224 while I rebase that one and work out the validation failure? |
Member
|
Doh! Thanks for pointing that out. Running the workflow now... |
Jevan Saks (jevansaks)
approved these changes
Apr 2, 2026
Member
|
I wonder if the validation failure is because the "check for changes" is expecting only one header with all the changes from that PR in the .txt file? I didn't get a chance to dig in either. But if this PR succeeds then I guess we can merge in 3 PRs for each of the updates. |
Contributor
Author
|
Closed in favour of being merged in via #2224. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.