Accept raw REGSAM access masks in open/create key helpers#641
Draft
benhillis wants to merge 1 commit into
Draft
Conversation
Introduce wil::reg::access_mask, a thin type implicitly constructible from either a named key_access value or a raw REGSAM mask. The open_*_key and create_*_key helpers now take access_mask instead of key_access, so callers can pass arbitrary access rights (e.g. KEY_QUERY_VALUE, KEY_READ | KEY_WOW64_64KEY) while existing key_access call sites continue to compile unchanged. get_access_flags now delegates to access_mask to keep a single mapping. Adds RegistryTests coverage for raw-mask open/create. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
access_masktype accepted by the open/create key helpers, implicitly constructible fromkey_accessor a raw REGSAM, so callers can pass custom access rights. Includes Catch2[registry]tests (and compile-time static_asserts) passing in normal & noexcept configs. Part of enabling WSL to drop its in-house registry helper in favor of wil::reg.