Skip to content

feat: add support for 32-bit registry access in key_access enum #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Brainy0207 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add support for 32-bit registry access in key_access enum #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions include/wil/registry_helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ namespace reg
// Access rights for opening registry keys. See https://learn.microsoft.com/en-us/windows/win32/sysinfo/registry-key-security-and-access-rights.
enum class key_access
{
// Open key for reading.
// Open key for reading. Equivalent to KEY_READ.
read,

// Open key for writing. Equivalent to KEY_WRITE.
Expand All @@ -74,14 +74,23 @@ namespace reg
// Open key for reading and writing. Equivalent to KEY_ALL_ACCESS.
readwrite,

// Open key for reading from 64-bit registry.
// Open key for reading from 64-bit registry. Equivalent to KEY_READ | KEY_WOW64_64KEY.
read64,

// Open key for writing from 64-bit registry. Equivalent to KEY_WRITE | KEY_WOW64_64KEY.
write64,

// Open key for reading and writing from 64-bit registry. Equivalent to KEY_ALL_ACCESS.
// Open key for reading and writing from 64-bit registry. Equivalent to KEY_ALL_ACCESS | KEY_WOW64_64KEY.
readwrite64,

// Open key for reading from 32-bit registry. Equivalent to KEY_READ | KEY_WOW64_32KEY.
read32,

// Open key for writing from 32-bit registry. Equivalent to KEY_WRITE | KEY_WOW64_32KEY.
write32,

// Open key for reading and writing from 32-bit registry. Equivalent to KEY_ALL_ACCESS | KEY_WOW64_32KEY.
readwrite32,
};

/// @cond
Expand Down Expand Up @@ -125,6 +134,12 @@ namespace reg
return KEY_WRITE | KEY_WOW64_64KEY;
case key_access::readwrite64:
return KEY_ALL_ACCESS | KEY_WOW64_64KEY;
case key_access::read32:
return KEY_READ | KEY_WOW64_32KEY;
case key_access::write32:
return KEY_WRITE | KEY_WOW64_32KEY;
case key_access::readwrite32:
return KEY_ALL_ACCESS | KEY_WOW64_32KEY;
}
FAIL_FAST();
RESULT_NORETURN_RESULT(0);
Expand Down