Add Select Subscriptions button to Resources view toolbar#1538
Add Select Subscriptions button to Resources view toolbar#1538alexweininger wants to merge 3 commits into
Conversation
Place the Select Subscriptions command between the group-by and refresh buttons in the Azure Resources view title bar. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR improves discoverability of the existing Select Subscriptions command by adding it to the Azure Resources view title toolbar, placing it between the existing Group By submenu and Refresh actions.
Changes:
- Added a
menus.view/titlecontribution forazureResourceGroups.selectSubscriptionsscoped toview == azureResourceGroupsatnavigation@3. - Shifted the existing refresh titlebar commands (
azureFocusView.refreshTree,azureResourceGroups.refreshTree) fromnavigation@3tonavigation@4to preserve the intended ordering.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds Select Subscriptions to the Azure Resources view title bar and adjusts toolbar ordering for refresh actions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
|
Matt H. approved |
|
Realized we probably need to hide this button in states where there's no subscriptions in the tree yet, @copilot can you look into that? What if the user isn't signed in yet, does the command handle it fine? Should we hide the button in some cases? |
The command already handles the "not signed in" case gracefully — it catches I've added a new context key
The toolbar button's |
|
@copilot what do we do for the other buttons on the ribbon, we should just handle this button the same as those. I think it's fine to keep it visible if the user isn't signed in yet if that's what we do for the other buttons and since the command handles the not signed in error gracefully. |
Reverted — the button now uses the same |
I've always wondering if this would provide a better UX. I've added the Select Subscriptions button to the title bar for the Azure Resources tree view.
What do we think? In my opinion this doesn't hurt anything, and can only help users who would potentially not see the button on the subscription items.