Skip to content

Fix remove-model in TypeSpec Java management generation #11698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Weidong Xu (weidongxu-microsoft) merged 2 commits into from
Aug 17, 2026
Merged

Fix remove-model in TypeSpec Java management generation #11698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa629e
fix(http-client-java): apply remove-model to TypeSpec generation
weidongxu-microsoft Aug 17, 2026
d677271
Delete packages/http-client-java/generator/http-client-generator-mgmt…
weidongxu-microsoft Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/http-client-java-remove-model-generation-2026-08-17.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-java"
---

Fix `remove-model` for TypeSpec management clients, including enum models.
4 changes: 3 additions & 1 deletion ...rator-mgmt/src/main/java/com/microsoft/typespec/http/client/generator/mgmt/FluentGen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,9 @@ protected FluentJavaPackage handleTemplate(Client client) {

// Enum
for (EnumType enumType : client.getEnums()) {
javaPackage.addEnum(enumType.getPackage(), enumType.getName(), enumType);
if (!getFluentJavaSettings().getJavaNamesForRemoveModel().contains(enumType.getName())) {
javaPackage.addEnum(enumType.getPackage(), enumType.getName(), enumType);
}
}

// XML sequence wrapper
Expand Down
3 changes: 2 additions & 1 deletion .../src/main/java/com/microsoft/typespec/http/client/generator/mgmt/mapper/FluentMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ public FluentMapper(FluentJavaSettings fluentJavaSettings) {

public void preModelMap(CodeModel codeModel) {
processInnerModel(codeModel);
FluentModelMapper.getInstance().addRemovedModels(fluentJavaSettings.getJavaNamesForRemoveModel());
((FluentModelMapper) Mappers.getModelMapper())
.addRemovedModels(fluentJavaSettings.getJavaNamesForRemoveModel());
}

public FluentClient map(CodeModel codeModel, Client client) {
Expand Down