Skip to content

Unify reflection helpers#7344

Open
Evangelink wants to merge 14 commits intomainfrom
dev/amauryleve/reflection
Open

Unify reflection helpers#7344
Evangelink wants to merge 14 commits intomainfrom
dev/amauryleve/reflection

Conversation

@Evangelink
Copy link
Copy Markdown
Member

@Evangelink Evangelink commented Feb 4, 2026

Fixes #3043

@Evangelink Evangelink marked this pull request as ready for review February 6, 2026 13:39
@Evangelink Evangelink enabled auto-merge February 6, 2026 13:39
Comment thread src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs Outdated
# Conflicts:
#	src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestPropertyAttributeTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TypeCacheTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Helpers/ReflectHelperTests.cs
…tion

# Conflicts:
#	src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Services/TestDeployment.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Utilities/DeploymentItemUtility.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Utilities/DeploymentUtilityBase.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Utilities/ReflectionOperationsNetFrameworkAttributeHelpers.cs
#	test/IntegrationTests/PlatformServices.Desktop.IntegrationTests/ReflectionUtilityTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Services/DesktopTestDeploymentTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Services/TestDeploymentTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/DeploymentItemUtilityTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/DeploymentUtilityTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/ReflectionUtilityTests.cs
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we are good now that everything uses the caching ReflectHelper on current main?

(Except that we need to investigate if it's possible to simplify the implementation of reflection operations under .NET Framework)

@Evangelink
Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

…tion

# Conflicts:
#	src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Discovery/TypeEnumerator.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Execution/TypeCache.cs
#	src/Adapter/MSTestAdapter.PlatformServices/Helpers/ReflectHelper.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Discovery/TestMethodValidatorTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Discovery/TypeEnumeratorTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TypeCacheTests.cs
#	test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/UnitTestRunnerTests.cs

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 17, 2026 18:40
@Evangelink Evangelink review requested due to automatic review settings April 17, 2026 18:40
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts and pushed the merge commit: 19c164645.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • k4kvsblobprodcus344.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.26211.1.txt (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify ReflectionUtility and ReflectionHelper classes

3 participants