Skip to content

Scroll sideways while holding the shift key and scroll fast while holding the alt key #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g-dg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Scroll sideways while holding the shift key and scroll fast while holding the alt key #766

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c06b1ea
Update to latest changes
g-dg Apr 29, 2026
d28353a
Move some scrolling logic to tui.rs
g-dg Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/edit/src/input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,10 +569,13 @@ impl<'input> Stream<'_, '_, 'input> {
// I know there's an InputMouseState::Release, but that's because the internals of tui.rs
// have leaked into intput.rs. input.rs indicates release by the absence of buttons being
// held, which is InputMouseState::None. This makes it more reliable in my opinion.
} else if (WHEEL..WHEEL + 4).contains(&kind) {
let delta = if (kind & 1) != 0 { 3 } else { -3 };
let idx = if (kind & 2) != 0 { 0 } else { 1 };
mouse.scroll.as_array()[idx] += delta;
} else if (WHEEL..WHEEL + 0x08).contains(&kind) {
let scroll_mult = if (btn & ALT) != 0 { 5 } else { 1 };
if (btn & 0x06) != 0 {
mouse.scroll.x += if (btn & 0x01) != 0 { 7 } else { -7 } * scroll_mult;
} else {
mouse.scroll.y += if (btn & 0x01) != 0 { 3 } else { -3 } * scroll_mult;
}
Copy link
Copy Markdown
Member

@lhecker lhecker Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This multiplication logic should go into tui.rs. Specifically, here:

edit/crates/edit/src/tui.rs

Line 623 in 3afb4f7

next_state = self.mouse_state;

(You need to make next_scroll a mutable variable for that.)

The reason for that is that input.rs' only concern is providing platform-independent input events. When we later add a fully customizable key binding editor, your key bindings should still have almost raw access to the input events. This allows a user to e.g. change the multiplier when Shift/Alt is held during scrolling.

Right now, all of the key binding logic is hardcoded in tui.rs, so it makes sense if these two key bindings also go there.

Copy link
Copy Markdown
Author

@g-dg g-dg Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Would it also be a good idea to move the base scroll amounts (3 lines & 7 characters) to tui.rs as well?

I think that if fast scroll multiplication should be abstracted in the TUI layer, then the base scroll amounts should probably also be abstracted in the TUI layer.

mouse.state = InputMouseState::Scroll;
} else if (kind & !MOTION) < 3 {
match kind & 3 {
Expand Down