Fix duplicate Alt+C access keys on Clear history/memory buttons (a11y)#2478
Merged
emmche merged 1 commit intoJun 26, 2026
Merged
Conversation
Currency, Clear all history, and Clear all memory all declared access key "C" in en-US/Resources.resw, which Accessibility Insights flags as a duplicate access key violation. Keep "C" for Currency and give the two Clear buttons unique mnemonic access keys: - ClearHistory.AccessKey: C -> Y (clear historY) - ClearMemory.AccessKey: C -> R (cleaR memory) en-US only; other locales are updated by the localized-strings pipeline.
veler
approved these changes
Jun 26, 2026
emmche
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accessibility Insights flagged a duplicate access key: three controls all declared
Alt+Cinen-US/Resources.resw:CategoryName_CurrencyAccessKey— Currency converter nav itemClearHistory.AccessKey— Clear all historyClearMemory.AccessKey— Clear all memoryMicrosoft accessibility guidelines require access keys to be unique across the visual tree. This PR keeps
Cfor Currency (the natural mnemonic) and assigns unique, mnemonic access keys to the two Clear buttons:ClearHistory.AccessKey:C→Y(clear historY)ClearMemory.AccessKey:C→R(cleaR memory)Both replacement letters appear in the visible button label, so the underlined mnemonic renders sensibly, and neither collides with any other access key in the resource set or with any
Alt-based keyboard accelerator (onlyAlt+Up/Alt+Downexist).Only
en-US/Resources.reswis changed; the other locale files are updated separately by the localized-strings pipeline, per existing repo convention.How changes were validated
*.AccessKeyvalue inResources.reswand every hardcodedAccessKey="..."in XAML, grouped by value:Cnow appears once (Currency), andY/Reach appear once — no duplicates introduced.AutomationId(ClearHistoryButton,PanelClearMemoryButton), unaffected by the access-key change.