Skip to content

Replace yargs-parser with commander for CLI option parsing #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Replace yargs-parser with commander for CLI option parsing #1192

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f9c491f
Convert CLI option parsing from yargs-parser to commander
Copilot Mar 28, 2026
cdd3f2e
Address code review: add config conflict error and camelCase rejectio…
Copilot Mar 28, 2026
7ac5cac
plan
Copilot Mar 28, 2026
59743dd
fix: update argv in test files to include required command name
Copilot Mar 28, 2026
617f887
Restructure CLI to use commander subcommands with proper help text
Copilot Mar 28, 2026
44c6910
Address review: combine unknown option tests, make --config primary w…
Copilot Mar 28, 2026
52259fe
Address review: remove redundant comment lines and test, add TODO for…
Copilot Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@
},
"dependencies": {
"@vercel/detect-agent": "^1.2.1",
"commander": "^10.0.1",
"cosmiconfig": "^9.0.0",
"execa": "^5.0.0",
"minimatch": "^3.0.4",
"p-graph": "^1.1.2",
"p-limit": "^3.0.2",
"prompts": "^2.4.2",
"semver": "^7.0.0",
"workspace-tools": "^0.41.0",
"yargs-parser": "^21.0.0"
"workspace-tools": "^0.41.0"
},
"devDependencies": {
"@jest/globals": "^29.0.0",
Expand All @@ -70,7 +70,6 @@
"@types/prompts": "^2.4.2",
"@types/semver": "^7.3.13",
"@types/tmp": "^0.2.3",
"@types/yargs-parser": "^21.0.0",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"@typescript-eslint/parser": "^5.0.0",
"@typescript-eslint/utils": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/__e2e__/bump.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('bump command', () => {
function getOptions(repoOptions?: Partial<RepoOptions>, cwd?: string) {
const parsedOptions = getParsedOptions({
cwd: cwd || repo?.rootPath || '',
argv: [],
argv: ['node', 'beachball', 'bump'],
testRepoOptions: { branch: defaultRemoteBranchName, fetch: false, ...repoOptions },
});
return { options: parsedOptions.options, parsedOptions };
Expand Down
2 changes: 1 addition & 1 deletion src/__e2e__/getChangedPackages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('getChangedPackages (basic)', () => {
function getChangedPackagesWrapper(options?: Partial<BeachballOptions>) {
const parsedOptions = getParsedOptions({
cwd: reusedRepo.rootPath,
argv: [],
argv: ['node', 'beachball', 'change'],
testRepoOptions: {
fetch: false,
branch: defaultRemoteBranchName,
Expand Down
2 changes: 1 addition & 1 deletion src/__e2e__/validate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('validate', () => {
function validateWrapper(validateOptions?: ValidateOptions) {
const parsedOptions = getParsedOptions({
cwd: repo!.rootPath,
argv: [],
argv: ['node', 'beachball', 'check'],
testRepoOptions: {
branch: defaultRemoteBranchName,
},
Expand Down
2 changes: 1 addition & 1 deletion src/__functional__/changefile/readChangeFiles.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('readChangeFiles', () => {
expect(cwd).toBeTruthy();
const parsedOptions = getParsedOptions({
cwd: cwd!,
argv: [],
argv: ['node', 'beachball', 'change'],
testRepoOptions: { branch: defaultRemoteBranchName, ...repoOptions },
});
const packageInfos = getPackageInfos(parsedOptions);
Expand Down
2 changes: 1 addition & 1 deletion src/__functional__/changelog/writeChangelog.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('writeChangelog', () => {
function getOptionsAndPackages(repoOptions?: Partial<RepoOptions>, cwd?: string) {
const parsedOptions = getParsedOptions({
cwd: cwd || repo?.rootPath || '',
argv: [],
argv: ['node', 'beachball', 'bump'],
testRepoOptions: { branch: defaultRemoteBranchName, ...repoOptions },
});
const packageInfos = getPackageInfos(parsedOptions);
Expand Down
Loading
Loading