MAINT Breaking: Remove MemoryExporter and export_conversations#1856
Open
rlundeen2 wants to merge 3 commits into
Open
MAINT Breaking: Remove MemoryExporter and export_conversations#1856rlundeen2 wants to merge 3 commits into
rlundeen2 wants to merge 3 commits into
Conversation
Deletes the MemoryExporter strategy class and its public consumers: - pyrit/memory/memory_exporter.py - MemoryInterface.export_conversations / self.exporter - SQLiteMemory.export_conversations override and export_all_tables - _ExportableConversationPiece helper - Associated unit tests and doc/code/memory/9_exporting_data notebook Users who need export can call get_message_pieces and serialize with pandas / json.dump directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
commented
May 29, 2026
|
|
||
| return seed_groups | ||
|
|
||
| def export_conversations( |
Contributor
Author
There was a problem hiding this comment.
I thought this made the most sense just to delete vs deprecate. But open to push back
Contributor
There was a problem hiding this comment.
We should deprecate. There's no harm in waiting for one release at least. I don't mind shortening it to just one release for this.
Contributor
Author
There was a problem hiding this comment.
Yeah, especially since we have a release coming up.
Maybe merge this pre-release: #1870
then we can merge this one post release
…ry-exporter # Conflicts: # pyrit/memory/memory_exporter.py # pyrit/memory/memory_interface.py # pyrit/memory/sqlite_memory.py # tests/unit/memory/memory_interface/test_interface_export.py # tests/unit/memory/test_memory_exporter.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the MemoryExporter strategy class and its public consumers:
Users who need export can use the output module or serialize directly