fix: omit registry URLs from tests lockfile - #3111
Open
Jamie Magee (JamieMagee) wants to merge 1 commit into
Open
fix: omit registry URLs from tests lockfile#3111Jamie Magee (JamieMagee) wants to merge 1 commit into
Jamie Magee (JamieMagee) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates test npm configuration to omit registry URLs from generated lockfiles while retaining the approved package proxy.
Changes:
- Adds
omit-lockfile-registry-resolved=truetotests/.npmrc. - Regenerates the test lockfile without registry URL metadata.
Show a summary per file
| File | Summary |
|---|---|
tests/.npmrc |
Enables lockfile registry URL omission while retaining the approved proxy. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
omit-lockfile-registry-resolved=truetotests/.npmrcwhile keeping the approved package proxy. Regeneratingtests/package-lock.jsonwith npm 11.11.1 removes 593resolvedfields without changing dependencies, integrity data,lockfileVersion, or other metadata.Validation:
npm config get registry:https://packagefeedproxy.microsoft.io/npm/npm config get omit-lockfile-registry-resolved:truepackage-lock.jsonSHA-256npm ci --ignore-scripts --no-audit --no-fundnpm ci --ignore-scripts --no-audit --no-fund && npm run buildfrom the repository rootcd tests && npm test(69 passed)cd tests && npm run typecheckcd tests && npm run lintChecklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:vally -- --plugin <plugin-dirname> --skill <skill>) (not applicable)Related Issues
Fixes #3110