Skip to content

feature: polish appinsights-instrumentation skill - #3107

Open
JasonYeMSFT (JasonYeMSFT) wants to merge 2 commits into
microsoft:mainfrom
JasonYeMSFT:chuye/appinsights-instrumentation-refresh
Open

feature: polish appinsights-instrumentation skill#3107
JasonYeMSFT (JasonYeMSFT) wants to merge 2 commits into
microsoft:mainfrom
JasonYeMSFT:chuye/appinsights-instrumentation-refresh

Conversation

@JasonYeMSFT

Copy link
Copy Markdown
Member

Description

Polish appinsights-instrumentation skill content:

  • Removed content that aren't of much value. There is no point describing when to use the skill in the skill body since it doesn't help routing.
  • Added a missing bullet point for python app
  • Added an explicit instruction to persuade the LLM to make code changes

Additional note:

I ran a set of comparison tests for this skill using the comparison script. The result indicates the skill brings two differentiating benefits:

  1. Consistently prevents the LLM from importing random 3rd party packages. Some no-skill runs end up suggesting a deprecated 3rd package "opencensus-ext-azure".
  2. Recommends codeless auto-instrument approach for C# ASP.NET apps. No-skill runs frequently fail to mention it when it's available.

Checklist

  • Tests pass locally (cd tests && npm test)
  • Title has one of the prefixes: fix:, feat:, feature:, chore:, misc:, test:, eval:
  • If modifying skill descriptions: verified routing correctness with integration tests (In tests/, npm run test:vally -- --plugin <plugin-dirname> --skill <skill>)

Related Issues

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request polishes the Application Insights instrumentation skill by adding Python support and clarifying instrumentation guidance.

Changes:

  • Adds Python apps to the prerequisites.
  • Removes body-level routing guidance.
  • Encourages applying code changes when tools are available.
Show a summary per file
File Review summary
plugins/azure-skills/skills/appinsights-instrumentation/SKILL.md Restore the required “When to Use This Skill” section and scope code-editing instructions to manual instrumentation.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (2)

plugins/azure-skills/skills/appinsights-instrumentation/SKILL.md:51

  • This change removes the only When to Use This Skill section, while this service skill still has no Quick Reference, MCP Tools, Workflow/Steps, or Error Handling sections. Those sections are required for every plugins/*/skills/**/SKILL.md; please restore/add the required structure rather than removing the section.
If you have tools to edit code, make the changes and explain what they do. Otherwise, show what changes need to be made.

plugins/azure-skills/skills/appinsights-instrumentation/SKILL.md:51

  • After this edit, the SKILL.md is still roughly 3,200 characters (about 800 tokens at the repository's 4-character estimate), above the <500 token target. The new sentence adds more prose while detailed resource and SDK procedures already live in references; move that detail behind links and keep this file as a concise workflow/index.
If you have tools to edit code, make the changes and explain what they do. Otherwise, show what changes need to be made.
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

Comment thread plugins/azure-skills/skills/appinsights-instrumentation/SKILL.md
Comment thread plugins/azure-skills/skills/appinsights-instrumentation/SKILL.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants