Skip to content

ci: temporarily disable offload tests while artifact publishing is broken - #8723

Closed
damyanp wants to merge 1 commit into
microsoft:mainfrom
damyanp:disable-offload-tests-artifact-outage
Closed

ci: temporarily disable offload tests while artifact publishing is broken#8723
damyanp wants to merge 1 commit into
microsoft:mainfrom
damyanp:disable-offload-tests-artifact-outage

Conversation

@damyanp

@damyanp damyanp commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

Azure Artifacts publishing is currently failing across the entire DirectXShaderCompiler Azure DevOps organization:

##[error]Artifact cannot be uploaded because max quantity has been exceeded
or the payment instrument is invalid. https://aka.ms/artbilling for details.

main is currently red because of this, along with every open PR. This is a temporary measure to get CI green again while the underlying billing issue is sorted out.

Impact

Every run since ~11:25 on 2026-07-30 has failed on the Publish DXC binaries step:

Build Branch Started Result
10659 PR 8672 10:32 last clean run
10660-10664 PRs 8673-8677 11:25-14:52 artifact publish failure
10667 PR 8718 18:04 artifact publish failure
10668 main 18:31 artifact publish failure
10670 PR 8666 19:35 artifact publish failure
10671 PR 8717 20:26 artifact publish failure

On main (10668) it also cascades: the missing artifact fails Download DXC binaries, which takes down both the WARP and lavapipe offload jobs.

Why the pipeline cannot just publish less

Pipeline artifacts are exempt from Azure Artifacts storage billing, so this is not a quota the pipeline can stay under by shrinking or expiring the artifact. The error string covers two conditions, and this is the payment instrument half - an org-level billing problem. Project retention settings are already tight (10 days, PipelineArtifact included in artifactTypesToDelete), so there is no headroom to reclaim there either.

The real fix is under Organization settings > Billing and needs someone with Project Collection Administrator access.

Change

The offload tests hand the built binaries from the Windows build job to the test jobs via a pipeline artifact, so they cannot run at all until publishing works. This adds an enableOffloadTests parameter, defaulted to false, which:

  • clears artifactName on the VS2022_Release matrix leg, so the existing ne(variables['artifactName'], '') guard skips both Stage DXC binaries and Publish DXC binaries - the same mechanism VS2022_Debug and VS2022_Release_NoSPIRV already use, so no new logic
  • forces the OffloadTests stage condition to false, so it never attempts the download that is guaranteed to fail

OffloadGate still runs. It takes ~6 seconds and always passes, and leaving it in place keeps the published check name stable.

Reverting

One word, once org billing is fixed:

  - name: enableOffloadTests
    default: false   # -> true

Trade-off

This does mean no offload test coverage on main while it is in effect. That is unavoidable given the transport is the thing that is broken, but it is worth restoring promptly rather than letting the flag quietly become permanent.

Release notes

Skipping per CONTRIBUTING.md - infrastructure-only change with no user-visible compiler behavior change.

…oken

Azure Artifacts publishing is currently failing across the whole
DirectXShaderCompiler ADO organization:

  ##[error]Artifact cannot be uploaded because max quantity has been
  exceeded or the payment instrument is invalid.
  https://aka.ms/artbilling for details.

Every run since 2026-07-30 ~11:25 has failed on the 'Publish DXC
binaries' step, including main. Pipeline artifacts are exempt from
Azure Artifacts storage billing, so this is a billing/payment
instrument problem on the organization rather than a quota that the
pipeline can avoid by publishing less.

The offload tests transfer the built binaries from the Windows build
job to the test jobs via a pipeline artifact, so they cannot run until
that is resolved. Downstream the missing artifact also fails the
'Download DXC binaries' step, taking the WARP and lavapipe jobs with
it.

Add an 'enableOffloadTests' parameter, defaulted to false, which:

  - clears artifactName on the VS2022_Release matrix leg, so the
    existing ne(variables['artifactName'], '') guard skips both the
    staging and publishing steps, and
  - forces the OffloadTests stage condition to false so it does not
    attempt a download that is guaranteed to fail.

This is a temporary measure. Once organization billing is fixed, flip
the default back to true to restore offload test coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f420f50f-9764-46ae-bb03-64b5913ea67e
Copilot AI review requested due to automatic review settings July 30, 2026 23:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Temporarily restores CI reliability while Azure pipeline artifact publishing is unavailable.

Changes:

  • Adds an offload-test feature flag, disabled by default.
  • Skips binary artifact publishing and the dependent offload-test stage when disabled.
  • Preserves the existing OffloadGate check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanp
damyanp enabled auto-merge (squash) July 30, 2026 23:43
Comment thread azure-pipelines.yml
condition: and(succeeded(), ne(variables['artifactName'], ''))
inputs:
targetPath: '$(Build.ArtifactStagingDirectory)\dxc'
artifact: '$(artifactName)'

@joaosaffran joaosaffran Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lavapipe tests only happen if we pass the label run-offload-tests in the PR. To disable the actual uploading, this task should be conditioned, something like:

Suggested change
- task: PublishPipelineArtifact@1
condition: eq(parameters.enableOffloadTests, 'true')
displayName: 'Publish DXC binaries'
condition: and(succeeded(), ne(variables['artifactName'], ''))
inputs:
targetPath: '$(Build.ArtifactStagingDirectory)\dxc'
artifact: '$(artifactName)'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or set artifactName to '' should also work

@damyanp
damyanp disabled auto-merge July 31, 2026 00:16
@damyanp

damyanp commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

It looks like I've managed to increase the storage limits - I'll abandon this change once I'm sure that builds are working again.

@damyanp damyanp closed this Jul 31, 2026
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants