ci: temporarily disable offload tests while artifact publishing is broken - #8723
Closed
damyanp wants to merge 1 commit into
Closed
ci: temporarily disable offload tests while artifact publishing is broken#8723damyanp wants to merge 1 commit into
damyanp wants to merge 1 commit into
Conversation
…oken Azure Artifacts publishing is currently failing across the whole DirectXShaderCompiler ADO organization: ##[error]Artifact cannot be uploaded because max quantity has been exceeded or the payment instrument is invalid. https://aka.ms/artbilling for details. Every run since 2026-07-30 ~11:25 has failed on the 'Publish DXC binaries' step, including main. Pipeline artifacts are exempt from Azure Artifacts storage billing, so this is a billing/payment instrument problem on the organization rather than a quota that the pipeline can avoid by publishing less. The offload tests transfer the built binaries from the Windows build job to the test jobs via a pipeline artifact, so they cannot run until that is resolved. Downstream the missing artifact also fails the 'Download DXC binaries' step, taking the WARP and lavapipe jobs with it. Add an 'enableOffloadTests' parameter, defaulted to false, which: - clears artifactName on the VS2022_Release matrix leg, so the existing ne(variables['artifactName'], '') guard skips both the staging and publishing steps, and - forces the OffloadTests stage condition to false so it does not attempt a download that is guaranteed to fail. This is a temporary measure. Once organization billing is fixed, flip the default back to true to restore offload test coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f420f50f-9764-46ae-bb03-64b5913ea67e
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily restores CI reliability while Azure pipeline artifact publishing is unavailable.
Changes:
- Adds an offload-test feature flag, disabled by default.
- Skips binary artifact publishing and the dependent offload-test stage when disabled.
- Preserves the existing
OffloadGatecheck.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
damyanp
enabled auto-merge (squash)
July 30, 2026 23:43
bob80905
approved these changes
Jul 30, 2026
joaosaffran
reviewed
Jul 30, 2026
| condition: and(succeeded(), ne(variables['artifactName'], '')) | ||
| inputs: | ||
| targetPath: '$(Build.ArtifactStagingDirectory)\dxc' | ||
| artifact: '$(artifactName)' |
Collaborator
There was a problem hiding this comment.
Lavapipe tests only happen if we pass the label run-offload-tests in the PR. To disable the actual uploading, this task should be conditioned, something like:
Suggested change
| - task: PublishPipelineArtifact@1 | |
| condition: eq(parameters.enableOffloadTests, 'true') | |
| displayName: 'Publish DXC binaries' | |
| condition: and(succeeded(), ne(variables['artifactName'], '')) | |
| inputs: | |
| targetPath: '$(Build.ArtifactStagingDirectory)\dxc' | |
| artifact: '$(artifactName)' |
Collaborator
There was a problem hiding this comment.
Or set artifactName to '' should also work
damyanp
disabled auto-merge
July 31, 2026 00:16
Member
Author
|
It looks like I've managed to increase the storage limits - I'll abandon this change once I'm sure that builds are working again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Azure Artifacts publishing is currently failing across the entire
DirectXShaderCompilerAzure DevOps organization:mainis currently red because of this, along with every open PR. This is a temporary measure to get CI green again while the underlying billing issue is sorted out.Impact
Every run since ~11:25 on 2026-07-30 has failed on the
Publish DXC binariesstep:On
main(10668) it also cascades: the missing artifact failsDownload DXC binaries, which takes down both the WARP and lavapipe offload jobs.Why the pipeline cannot just publish less
Pipeline artifacts are exempt from Azure Artifacts storage billing, so this is not a quota the pipeline can stay under by shrinking or expiring the artifact. The error string covers two conditions, and this is the payment instrument half - an org-level billing problem. Project retention settings are already tight (10 days,
PipelineArtifactincluded inartifactTypesToDelete), so there is no headroom to reclaim there either.The real fix is under Organization settings > Billing and needs someone with Project Collection Administrator access.
Change
The offload tests hand the built binaries from the Windows build job to the test jobs via a pipeline artifact, so they cannot run at all until publishing works. This adds an
enableOffloadTestsparameter, defaulted tofalse, which:artifactNameon theVS2022_Releasematrix leg, so the existingne(variables['artifactName'], '')guard skips bothStage DXC binariesandPublish DXC binaries- the same mechanismVS2022_DebugandVS2022_Release_NoSPIRValready use, so no new logicOffloadTestsstageconditiontofalse, so it never attempts the download that is guaranteed to failOffloadGatestill runs. It takes ~6 seconds and always passes, and leaving it in place keeps the published check name stable.Reverting
One word, once org billing is fixed:
Trade-off
This does mean no offload test coverage on
mainwhile it is in effect. That is unavoidable given the transport is the thing that is broken, but it is worth restoring promptly rather than letting the flag quietly become permanent.Release notes
Skipping per
CONTRIBUTING.md- infrastructure-only change with no user-visible compiler behavior change.