Efficiency: remove unnecessary copy operation - #288
Open
MetRonnie wants to merge 1 commit into
Open
Conversation
MetRonnie
commented
Jun 29, 2026
| for attr in self.__slots__: | ||
| value = getattr(self, attr, None) | ||
| if callable(getattr(value, "_copy", None)): | ||
| value = value._copy() |
Contributor
Author
There was a problem hiding this comment.
I am convinced this copy was unnecessary. Note it's the time zone that was being copied. The only uses of this method:
- In the comparison function, where no references to the time zone are created
- In
def get_timepoint_properties_from_seconds_since_unix_epoch(), where a local reference to the time zone is created, but not mutated
Member
There was a problem hiding this comment.
I think you are right.
The only mutable property returned is the time zone. This is a TimeZone(Duration) object which is __hash__able. It provides no methods that would mutate the object, you would have to meddle with a _ prefixed variable to mess it up.
Seems reasonable.
oliver-sanders
approved these changes
Jul 30, 2026
oliver-sanders
left a comment
oliver-sanders
left a comment
Member
There was a problem hiding this comment.
This looks good to me, but we don't actually have any tests for this method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #285