Make image decoders available when FFmpeg is missing#1544
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1544
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 14 PendingAs of commit c57a324 with merge base f561b0e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the image decoders we recently added do not depend on FFmpeg. So we shouldn't make FFmpeg a hard dependency anymore. In
main,import torchcodecwould error if the FFmpeg libraries aren't found. Now, we should only error when FFmpeg functionality is explicitly required (video decoding, etc.).Not handled here:
WavDecoder, which doesn't rely on FFmpeg for decoding, but actually still links to FFmpeg's AVIO somehow. We could probably work that out but that's not critical.This is a large diff but most of it is just moving all the ffmpeg-dependent ops from
ops.pyinto a new_ffmpeg_ops.pyfile. The rest are tests and plumbing.