Skip to content

fix(power): use BQ25896 ADC for both battery voltage and presence #10442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DatanoiseTV wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix(power): use BQ25896 ADC for both battery voltage and presence #10442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Power.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,9 +1668,14 @@ class LipoCharger : public HasBatteryLevel
}

/**
* The raw voltage of the battery in millivolts, or NAN if unknown
* The raw voltage of the battery in millivolts, or 0 if unknown.
* Use the BQ25896 charger ADC for both voltage and presence detection so
* the two readings can never disagree. The BQ27220 fuel gauge can report
* 0 / stale on a freshly-attached cell before its initial learn cycle
* finishes, which would make hasBattery=false but voltage=4.0V — the
* upstream PowerFSM then thinks the device is externally powered.
*/
virtual uint16_t getBattVoltage() override { return bq->getVoltage(); }
virtual uint16_t getBattVoltage() override { return PPM->getBattVoltage(); }

/**
* return true if there is a battery installed in this unit
Expand Down
Loading