Skip to content

Router::allocForSending: null-check packet pool allocation #10261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightjoker7 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Router::allocForSending: null-check packet pool allocation #10261

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a77c93
Router::allocForSending: null-check packet pool allocation
nightjoker7 Apr 23, 2026
931f2ed
Update src/mesh/Router.cpp
thebentern Apr 23, 2026
43bb584
Audit allocForSending() callers + null-check unsafe ones
nightjoker7 Apr 23, 2026
ac1dddc
Address Copilot caller-audit follow-ups: ProtobufModule null-safe + s…
nightjoker7 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/mesh/Router.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,10 @@ PacketId generatePacketId()
meshtastic_MeshPacket *Router::allocForSending()
{
meshtastic_MeshPacket *p = packetPool.allocZeroed();
if (!p) {
LOG_ERROR("allocForSending: packet pool exhausted");
Comment thread
thebentern marked this conversation as resolved.
Outdated
return nullptr;
}

p->which_payload_variant = meshtastic_MeshPacket_decoded_tag; // Assume payload is decoded at start.
p->from = nodeDB->getNodeNum();
Expand Down
Loading