Skip to content

MeshService: null-check sender node before dereferencing has_user on hot RX path #10229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightjoker7 wants to merge 5 commits into
base: develop
Choose a base branch
from
+15 −10
Open

MeshService: null-check sender node before dereferencing has_user on hot RX path #10229

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39cf4af
MeshService: null-check sender node before dereferencing has_user on …
nightjoker7 Apr 21, 2026
2d7aa92
Merge branch 'develop' into fix/meshservice-from-node-null-deref
thebentern Apr 22, 2026
6b7fbce
Merge branch 'develop' into fix/meshservice-from-node-null-deref
thebentern Apr 23, 2026
c6e6bb2
Merge remote-tracking branch 'origin/develop' into fix/meshservice-fr…
nightjoker7 Apr 23, 2026
a6a93d2
Address Copilot review: cache getMeshNode lookup on hot RX path
nightjoker7 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mesh/MeshService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ int MeshService::handleFromRadio(const meshtastic_MeshPacket *mp)
mp->decoded.portnum == meshtastic_PortNum_TELEMETRY_APP && mp->decoded.request_id > 0) {
LOG_DEBUG("Received telemetry response. Skip sending our NodeInfo");
// ignore our request for its NodeInfo
} else if (mp->which_payload_variant == meshtastic_MeshPacket_decoded_tag && !nodeDB->getMeshNode(mp->from)->has_user &&
nodeInfoModule && !isPreferredRebroadcaster && !nodeDB->isFull()) {
} else if (mp->which_payload_variant == meshtastic_MeshPacket_decoded_tag && nodeDB->getMeshNode(mp->from) != nullptr &&
!nodeDB->getMeshNode(mp->from)->has_user && nodeInfoModule && !isPreferredRebroadcaster && !nodeDB->isFull()) {
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getMeshNode(mp->from) is now called twice in the same condition. NodeDB::getMeshNode() performs a linear scan over numMeshNodes, so on this hot RX path this doubles the lookup work for packets where the node exists. Consider caching the pointer in a local variable (or otherwise restructuring the condition) so the node lookup happens once and the subsequent has_user check uses the same result.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@thebentern thebentern Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

if (airTime->isTxAllowedChannelUtil(true)) {
const int8_t hopsUsed = getHopsAway(*mp, config.lora.hop_limit);
if (hopsUsed > (int32_t)(config.lora.hop_limit + 2)) {
Expand Down
Loading