Skip to content

[chore] Update Go version to 1.25 and align GitHub Actions#490

Open
Suhani95 wants to merge 7 commits intomeshery-extensions:masterfrom
Suhani95:chore/update-go-1.25
Open

[chore] Update Go version to 1.25 and align GitHub Actions#490
Suhani95 wants to merge 7 commits intomeshery-extensions:masterfrom
Suhani95:chore/update-go-1.25

Conversation

@Suhani95
Copy link
Copy Markdown

@Suhani95 Suhani95 commented Dec 19, 2025

Description

This PR fixes #489

Changes made :

  • Updates the Go version used in this repository from 1.24 to 1.25.

  • Updates GitHub Action version tags across the workflows to their latest stable releases.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Suhani95 and others added 2 commits December 19, 2025 15:35
Signed-off-by: Suhani <suhani4630@gmail.com>
Signed-off-by: suhani <168286988+Suhani95@users.noreply.github.com>
@Suhani95
Copy link
Copy Markdown
Author

@mgfeller Would like a review on the changes made, and open to any suggestions.
Thank you for your time

@mgfeller
Copy link
Copy Markdown

@Suhani95 thanks for your contribution and for reaching out. It looks good, however I'm hesitant to approve the PR as I haven't been actively involved in a while and would have to be reacquainted with the approval and merge process.

@Suhani95
Copy link
Copy Markdown
Author

Totally understand. I'll wait for an active maintainer to take a look.

@Suhani95
Copy link
Copy Markdown
Author

@saurabhraghuvanshii could you please review this PR?
Please let me know if you have any feedback or suggested changes!

@saurabhraghuvanshii
Copy link
Copy Markdown
Member

saurabhraghuvanshii commented Dec 21, 2025

@Suhani95 golangci-lint faling, I think some migrations not working can you see

Signed-off-by: Suhani <suhani4630@gmail.com>
@Suhani95
Copy link
Copy Markdown
Author

@saurabhraghuvanshii Fixed linter migration issues by updating the config schema. Please review.

Comment thread .github/workflows/components-to-doc.yml
Comment thread .github/workflows/slack.yml
runs-on: ubuntu-latest
steps:
- name: Notify Slack
uses: slackapi/slack-github-action@v2.1.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Comment thread .golangci.yaml
Comment thread kuma/sample_apps.go
@saurabhraghuvanshii
Copy link
Copy Markdown
Member

@Suhani95 come minimum changes required, Please address them

….yml

Signed-off-by: Suhani <suhani4630@gmail.com>
Comment thread .golangci.yaml
Signed-off-by: Suhani <suhani4630@gmail.com>
@saurabhraghuvanshii
Copy link
Copy Markdown
Member

@Suhani95 some Improtant things are missing from .golangci

  1. Missing linters
    - gosimple
    - stylecheck
    - typecheck
  1. Missing gosec exclusion under linters.settings
    gosec:
      settings:
        exclude:
          - G204
  1. Missing goimports local-prefixes
    Add under formatters:
formatters:
  settings:
    goimports:
      local-prefixes: github.com/golangci/golangci-lint

Signed-off-by: Suhani <suhani4630@gmail.com>
@Suhani95
Copy link
Copy Markdown
Author

Suhani95 commented Jan 7, 2026

@saurabhraghuvanshii
gosimple and stylecheck are already handled by staticcheck in v2, and typecheck now runs by default, so adding them explicitly causes errors.
I have added gosec G204 exclusion and the goimports local-prefixes now to keep behavior consistent.
Migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] Update to Golang 1.25

3 participants