Skip to content

Firefox/Safari don't support InstallEvent interface#28918

Merged
caugner merged 7 commits intomainfrom
22591-InstallEvent-in-Firefox-and-Safari
Feb 13, 2026
Merged

Firefox/Safari don't support InstallEvent interface#28918
caugner merged 7 commits intomainfrom
22591-InstallEvent-in-Firefox-and-Safari

Conversation

@caugner
Copy link
Copy Markdown
Contributor

@caugner caugner commented Jan 26, 2026

Summary

Update Firefox/Safari statements for InstallEvent interface.

Test results and supporting details

Both "only" support the install event, but it is of type ExtendableEvent, not InstallEvent.

Related issues

Opened openwebdocs/mdn-bcd-collector#3020 to update the collector test.

Fixes #22591.

@caugner caugner requested a review from Elchi3 January 26, 2026 16:58
@github-actions github-actions Bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:s [PR only] 7-24 LoC changed labels Jan 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 26, 2026

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Comment thread api/InstallEvent.json Outdated
@caugner caugner requested a review from ddbeck February 6, 2026 10:37
Copy link
Copy Markdown
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both "only" support the install event, but it is of type ExtendableEvent, not InstallEvent.

This suggests to me that api.ServiceWorkerGlobalScope.install_event needs a note to indicate the type sent to an event listener is not the correct type. (It's probably not partial though, if this is the first we're noticing of it.)

@caugner
Copy link
Copy Markdown
Contributor Author

caugner commented Feb 12, 2026

This suggests to me that api.ServiceWorkerGlobalScope.install_event needs a note to indicate the type sent to an event listener is not the correct type. (It's probably not partial though, if this is the first we're noticing of it.)

Good point, added in ac825c3.

@caugner caugner requested review from ddbeck and removed request for Elchi3 February 12, 2026 09:13
Copy link
Copy Markdown
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with a comment to improve the text of the event notes.

Comment thread api/ServiceWorkerGlobalScope.json Outdated
@caugner caugner enabled auto-merge (squash) February 13, 2026 21:04
@caugner caugner merged commit 0c8d2e2 into main Feb 13, 2026
13 checks passed
@caugner caugner deleted the 22591-InstallEvent-in-Firefox-and-Safari branch February 13, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:s [PR only] 7-24 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api.InstallEvent - does not exist in Firefox nor in Safari

2 participants