Skip to content

Make talk updated_at property optional #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbernson merged 1 commit into from
Apr 6, 2026
Merged

Make talk updated_at property optional #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CCCApi/Sources/CCCApi/Models/Conference.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public struct Conference: Decodable, Identifiable, Sendable {
public let acronym: String
public let slug: String
public let title: String
public let updatedAt: Date
public let updatedAt: Date?
public let eventLastReleasedAt: Date?
public let events: [Talk]?
public let link: URL?
Expand All @@ -31,7 +31,7 @@ public struct Conference: Decodable, Identifiable, Sendable {
public var id: String { slug }

init(
acronym: String, slug: String, title: String, updatedAt: Date,
acronym: String, slug: String, title: String, updatedAt: Date?,
eventLastReleasedAt: Date? = nil, events: [Talk]? = nil, link: URL? = nil,
description: String? = nil, aspectRatio: AspectRatio? = nil, webgenLocation: String,
url: URL, logoURL: URL, imagesURL: URL? = nil, recordingsURL: URL? = nil
Expand Down Expand Up @@ -75,7 +75,7 @@ public struct Conference: Decodable, Identifiable, Sendable {
acronym = try container.decode(String.self, forKey: .acronym)
slug = try container.decode(String.self, forKey: .slug)
title = try container.decode(String.self, forKey: .title)
updatedAt = try container.decode(Date.self, forKey: .updatedAt)
updatedAt = try container.decode(Date?.self, forKey: .updatedAt)
eventLastReleasedAt = try container.decode(Date?.self, forKey: .eventLastReleasedAt)
events = try? container.decode([Event].self, forKey: .events)
link = try? container.decode(URL?.self, forKey: .link)
Expand Down
13 changes: 7 additions & 6 deletions HackerTube/Features/Conferences/ConferencesView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,14 @@ struct ConferencesView: View {
func refresh() async {
do {
conferences = try await api.conferences()
.filter { conference in
conference.eventLastReleasedAt != nil
}
.sorted { lhs, rhs in
let lhsVal = lhs.eventLastReleasedAt ?? lhs.updatedAt
let rhsVal = rhs.eventLastReleasedAt ?? rhs.updatedAt
return lhsVal > rhsVal
// Sort by updated at, falling back to title sort.
if let lhsUpdatedAt = lhs.eventLastReleasedAt ?? lhs.updatedAt,
let rhsUpdatedAt = rhs.eventLastReleasedAt ?? rhs.updatedAt {
return lhsUpdatedAt > rhsUpdatedAt
} else {
return lhs.title < rhs.title
}
}
} catch is CancellationError {
} catch {
Expand Down