Fix extra leading space in YearPicker#42
Closed
WZBbiao wants to merge 1 commit into
Closed
Conversation
The YearPicker was using Label("Year", systemImage: "calendar") which
displayed both the icon and the "Year" text. In the menu picker style
(used on both tvOS inline and iOS toolbar), this caused extra leading
space to appear before the year number since the label text was rendered
alongside the selected value.
Applying .labelStyle(.iconOnly) to the Picker removes the text portion
of the Label, showing only the calendar icon. This eliminates the extra
leading space while keeping the visual calendar indicator.
Fixes mbernson#40.
Owner
|
Hi, thanks for submitting a PR. I tried your patch but unfortunately the unexpected spacing was still there. ToolbarItem(placement: .topBarTrailing) {
Menu {
Picker("Year", selection: $year) { /* ... */ }
} label: {
Label("Year", systemImage: "calendar")
}
}Which is implemented in PR #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The year picker in the Popular talks view (used both in the tvOS inline view and the iOS toolbar) shows extra leading space before the year number. This was caused by the
Label("Year", systemImage: "calendar")displaying both the calendar icon and the "Year" text. In.pickerStyle(.menu), this results in the text appearing as unwanted padding before the selected year.Fix
Added
.labelStyle(.iconOnly)to thePicker, which makes the label closure render only the calendar icon without the "Year" text. This removes the extra leading space while keeping the visual calendar indicator.Fixes #40.