fix(source): align update notifications and retry semantics - #373
Open
maxlambrecht wants to merge 1 commit into
Open
fix(source): align update notifications and retry semantics#373maxlambrecht wants to merge 1 commit into
maxlambrecht wants to merge 1 commit into
Conversation
maxlambrecht
force-pushed
the
fix/source-update-retry-semantics
branch
7 times, most recently
from
July 20, 2026 18:55
023d516 to
9e14806
Compare
chore(spire-api): allow transitive crate version lint chore(spiffe): allow transitive crate version lint Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
force-pushed
the
fix/source-update-retry-semantics
branch
2 times, most recently
from
July 20, 2026 19:05
0d9aa3b to
dec2997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up from source lifecycle review findings for
X509SourceandJwtSource: update notifications could fire on reconnect without material changes, initial sync retried forever on Workload APIINVALID_ARGUMENT, and some X.509 Workload API behaviors needed clearer documentation.Changes
apply_update, soupdated()only notifies on actual material changes.X509Source/JwtSourceinitial sync fast on Workload API gRPCINVALID_ARGUMENT; steady-state reconnect behavior is unchanged.WorkloadApiError::is_invalid_argument().stream_x509_svids, SPIRE-specificNoIdentityIssuedmessage matching, and federated-bundle overwrite precedence.Security
Compatibility
updated()no longer fires for unchanged material re-delivered on reconnect.INVALID_ARGUMENTinstead of retrying indefinitely.spiffewithx509-source,jwt-source,workload-api-x509, andworkload-api-jwt.Testing
cargo fmt -p spiffe -- --checkcargo clippy -p spiffe --features x509-source,jwt-source,jwt-verify-rust-crypto,logging --testscargo test -p spiffe --lib --features x509-source,jwt-source,jwt-verify-rust-crypto,logging(224 passed)cargo doc -p spiffe --no-deps --features x509-source,jwt-source,jwt-verify-rust-crypto,loggingchecked; remaining unresolved links are pre-existing outside this change area.Release notes
updated()now ignores re-delivered, unchanged material and only notifies when the held context or bundle set changes.INVALID_ARGUMENTinstead of retrying forever.WorkloadApiError::is_invalid_argument().stream_x509_svids, SPIRE-specificNoIdentityIssuedmatching, and federated-bundle overwrite precedence.This change is