Alter event_reader definition - #33
Merged
Merged
Conversation
Contributor
Author
|
Previously the event_reader definition did not allow filtering multiple event types if an event had a leading or trailing whitespace after a comma. Example: types = "link leave, link enter" would have resulted in only reading the link leave event. While entering types = "link leave,link enter" would have resulted in reading both events. Therefore, the definition was altered to remove leading and trailing whitespaces. |
Collaborator
|
PR was approved after discussing in person. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event_reader definition was altered to remove leading and trailing white spaces from the event types if they are a string.