ACE removed. New network engine. OpenSSL 3.x mandatory. New mangosd UI.#448
21 new issues (0 max.) of at least minor severity.
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 4
- Added 21
Complexity increasing per file
==============================
- src/shared/Auth/Sha1.cpp 9
- src/shared/Log/Log.cpp 8
- src/shared/Threading/Threading.h 1
- src/game/WorldHandlers/World.cpp 2
- src/shared/Config/Config.cpp 13
- src/game/Maps/MapUpdater.cpp 6
- src/ipc/IpcLink.h 4
- src/ipc/IpcServerHandler.h 2
- src/ipc/WorkerSupervisor.h 1
- src/ipc/IpcProcess.cpp 25
- src/ipc/IpcProcess.h 3
- src/ipc/IpcSocket.cpp 53
- src/ipc/IpcSocket.h 7
- src/mangosd/Master.cpp 95
- src/mangosd/RASession.cpp 46
- src/mangosd/RASession.h 6
- src/mangosd/Service.h 1
- src/shared/Threading/ThreadLocalStore.h 2
- src/shared/Utilities/ConsoleStyle.cpp 65
- src/shared/Utilities/StartupUI.cpp 77
- src/shared/Utilities/StartupUI.h 1
- src/shared/Utilities/StartupUIDemo.cpp 7
- src/shared/net/BindAddress.cpp 6
- src/shared/net/FlowControl.hpp 7
- src/shared/net/ISession.hpp 9
- src/shared/net/SendQueue.hpp 13
- src/shared/net/Server.hpp 2
- src/shared/net/iocp/IocpServer.cpp 76
- src/shared/net/iocp/IocpServer.hpp 4
- src/shared/net/reactor/Connection.hpp 1
- src/shared/net/reactor/EpollPoller.cpp 21
- src/shared/net/reactor/EpollPoller.hpp 2
- src/shared/net/reactor/KqueuePoller.cpp 23
- src/shared/net/reactor/KqueuePoller.hpp 2
- src/shared/net/reactor/PollerFactory.cpp 3
- src/shared/net/reactor/ReactorServer.cpp 104
- src/shared/net/uring/UringServer.cpp 89
- src/shared/net/uring/UringServer.hpp 1
Complexity decreasing per file
==============================
+ src/modules/Bots/ahbot/AhBot.cpp -2
+ src/mangosd/mangosd.cpp -26
+ src/shared/Auth/ARC4.cpp -2
+ src/game/Server/WorldSocket.cpp -44
+ src/shared/Policies/Singleton.h -5
+ src/ipc/IpcChannel.cpp -2
+ src/ipc/IpcClientHandler.cpp -21
+ src/ipc/IpcServerHandler.cpp -29
+ src/ipc/WorkerSupervisor.cpp -4
+ src/game/WorldHandlers/ScriptMgrBinding.cpp -1
Clones added
============
- src/game/Server/WorldSocket.h 1
- src/ipc/IpcSocket.cpp 2
- src/mangosd/RASession.h 1
- src/shared/net/reactor/EpollPoller.hpp 1
- src/shared/net/reactor/KqueuePoller.hpp 1
- src/shared/net/reactor/ReactorServer.cpp 5
- src/shared/net/uring/UringServer.cpp 5
Clones removed
==============
+ src/ipc/IpcChannel.cpp -4
+ src/ipc/IpcClientHandler.h -1
+ src/ipc/IpcServerHandler.h -1
+ src/ipc/IpcThread.cpp -2
See the complete overview on Codacy
Annotations
Check warning on line 62 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L62
struct member 'AcceptOv::type' is never used.
Check warning on line 65 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L65
struct member 'AcceptOv::addrbuf' is never used.
Check warning on line 70 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L70
struct member 'RecvOv::type' is never used.
Check warning on line 72 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L72
struct member 'RecvOv::buf' is never used.
Check warning on line 80 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L80
struct member 'SendOv::type' is never used.
Check warning on line 165 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L165
class member 'IocpServer::m_workers' is never used.
Check warning on line 167 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L167
class member 'IocpServer::m_wsaStarted' is never used.
Check warning on line 169 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L169
class member 'IocpServer::PENDING_ACCEPTS' is never used.
Check warning on line 174 in src/shared/net/iocp/IocpServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/iocp/IocpServer.hpp#L174
class member 'IocpServer::m_conns' is never used.
Check warning on line 55 in src/shared/net/reactor/KqueuePoller.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/reactor/KqueuePoller.hpp#L55
class member 'KqueuePoller::kWakeIdent' is never used.
Check warning on line 67 in src/shared/net/reactor/ReactorServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/reactor/ReactorServer.hpp#L67
struct member 'Worker::incoming' is never used.
Check warning on line 68 in src/shared/net/reactor/ReactorServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/reactor/ReactorServer.hpp#L68
struct member 'Worker::conns' is never used.
Check warning on line 73 in src/shared/net/reactor/ReactorServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/reactor/ReactorServer.hpp#L73
struct member 'Worker::reqQueue' is never used.
Check warning on line 84 in src/shared/net/reactor/ReactorServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/reactor/ReactorServer.hpp#L84
class member 'ReactorServer::m_workers' is never used.
Check warning on line 99 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L99
struct member 'UringConn::recvBuf' is never used.
Check warning on line 127 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L127
class member 'UringServer::WAKE_DATA' is never used.
Check warning on line 129 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L129
class member 'UringServer::RING_ENTRIES' is never used.
Check warning on line 137 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L137
struct member 'Worker::incoming' is never used.
Check warning on line 138 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L138
struct member 'Worker::conns' is never used.
Check warning on line 142 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L142
struct member 'Worker::reqQueue' is never used.
Check warning on line 149 in src/shared/net/uring/UringServer.hpp
codacy-production / Codacy Static Code Analysis
src/shared/net/uring/UringServer.hpp#L149
class member 'UringServer::m_workers' is never used.