Skip to content

[WEB-7182] fix: remove profile preferences activity#9025

Open
b-saikrishnakanth wants to merge 1 commit intopreviewfrom
feat-remove-profile-preferences-activity
Open

[WEB-7182] fix: remove profile preferences activity#9025
b-saikrishnakanth wants to merge 1 commit intopreviewfrom
feat-remove-profile-preferences-activity

Conversation

@b-saikrishnakanth
Copy link
Copy Markdown
Collaborator

@b-saikrishnakanth b-saikrishnakanth commented May 6, 2026

Description

Removed the activity section under profile preferences along with api endpoint

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

  • Removals
    • Removed the Activity tab from profile settings. Users will no longer see the Activity section when accessing their profile preferences.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 79578603-4539-42dc-9636-41a4afdf473d

📥 Commits

Reviewing files that changed from the base of the PR and between 4c1bdd1 and 782c8c6.

📒 Files selected for processing (9)
  • apps/web/core/components/profile/activity/profile-activity-list.tsx
  • apps/web/core/components/settings/profile/content/pages/activity/activity-list.tsx
  • apps/web/core/components/settings/profile/content/pages/activity/index.ts
  • apps/web/core/components/settings/profile/content/pages/activity/root.tsx
  • apps/web/core/components/settings/profile/content/pages/index.ts
  • apps/web/core/components/settings/profile/sidebar/item-categories.tsx
  • apps/web/core/services/user.service.ts
  • packages/constants/src/settings/profile.ts
  • packages/types/src/settings.ts
💤 Files with no reviewable changes (7)
  • apps/web/core/components/settings/profile/content/pages/activity/root.tsx
  • apps/web/core/components/profile/activity/profile-activity-list.tsx
  • apps/web/core/components/settings/profile/content/pages/index.ts
  • apps/web/core/components/settings/profile/content/pages/activity/index.ts
  • apps/web/core/components/settings/profile/content/pages/activity/activity-list.tsx
  • packages/constants/src/settings/profile.ts
  • apps/web/core/services/user.service.ts

📝 Walkthrough

Walkthrough

The PR removes the activity tab from profile settings by deleting related components, service methods, and configuration entries across the application. This includes the activity list component, the getUserActivity service method, activity type definitions, and all references in the settings map and sidebar.

Changes

Activity Tab Removal

Layer / File(s) Summary
Type Definitions
packages/types/src/settings.ts
Removed "activity" option from TProfileSettingsTabs union type.
Constants & Configuration
packages/constants/src/settings/profile.ts
Removed activity entry from PROFILE_SETTINGS and its reference from GROUPED_PROFILE_SETTINGS YOUR_PROFILE group.
Service Layer
apps/web/core/services/user.service.ts
Removed getUserActivity() method and its signature.
Component Deletion
apps/web/core/components/profile/activity/profile-activity-list.tsx, apps/web/core/components/settings/profile/content/pages/activity/*
Deleted ProfileActivityListPage component and activity page files (index.ts, root.tsx, activity-list.tsx).
Integration & UI Updates
apps/web/core/components/settings/profile/content/pages/index.ts, apps/web/core/components/settings/profile/sidebar/item-categories.tsx
Removed activity key from PROFILE_SETTINGS_PAGES_MAP and removed Activity icon import and mapping from sidebar item categories.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A hop, a skip, away it flies,
The activity tab bids its goodbyes,
Clean and tidy, the code runs light,
Our settings now feel just right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal and vague. While it mentions removing the activity section and API endpoint, it lacks detail about scope, impact, and doesn't fill in the Test Scenarios section. Expand the description with more details about what was removed and why; add test scenarios to verify the activity tab is no longer accessible in profile preferences.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: removing profile preferences activity, which aligns with the changeset of deleting activity-related components, services, and constants.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-remove-profile-preferences-activity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@makeplane
Copy link
Copy Markdown

makeplane Bot commented May 6, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant