wrap setitem/setattr assign failures in PathAssignError - #304
Open
Sahana2524 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_assign_oponly turned failures intoPathAssignErrorfor the registry ('P') branch, so an assignment through a T-expression destination leaked the raw error instead:Assign(T[i], v)past the end of a list, or into an immutable tuple, surfaced a bareIndexError/TypeErrorwrapped by the generic traceAssign(T.attr, v)onto a read-only attribute did the same withAttributeErrorPathform already raisedPathAssignError, andDelete._del_onewraps all three op branches, so this was the odd one outWrapped the setitem and setattr branches the same way, which also matches what the
Assigndocstring already promises. Test covers the list, tuple, and attribute cases.