Added support from Folder Dict, Now you can create a Dict for a folde…#185
Added support from Folder Dict, Now you can create a Dict for a folde…#185AI-IshanBhatt wants to merge 3 commits intomahmoud:masterfrom
Conversation
…r and access their files like a dictionary
|
Are you still supporting Python 2.7 ? |
|
@AI-IshanBhatt The project readme mentions that the library is tested for python 2.6 and python 2.7 |
|
Let me change the code so that it works on all versions. Thanks man. |
|
Can anyone help me here? |
|
@AI-IshanBhatt Looks like a regression in python 3.7.1 as the code passes just fine on 3.7.0. It could also be OrderedMultiDict relying on some unspecified behavior of python3.7 dicts. |
|
I am a newbie in open source, Can you help me with what would be next steps? |
|
@AI-IshanBhatt There's no fixed next step. You could try and debug the problem with OrderedMultiDict and depending on the source of the problem, add a PR to either this repository or the cpython repository. Or if you are not interested in that, you could just wait for a maintainer to see the issue and decide whether it's ok to merge this PR despite the failed CI. |
|
@mahmoud Can you please look into this as well? |
|
Hey there! The 3.7 issue has been fixed on master, which closed #179. If you rebase you should see things pass. I'm still contemplating where to include this. I think this probably fits best in |
Now you can create a Dict for a folder and access their files like a dictionary.
The opening of a file, closing of a file is done automatically.
Also, the listing of files is supported by dict.keys()
File deletion is supported by del dict["File_name"] or dict.pop("File_Name")