fix: add dismissible large file warning banner for files over 500MB#1563
Open
AKIB2005 wants to merge 2 commits into
Open
fix: add dismissible large file warning banner for files over 500MB#1563AKIB2005 wants to merge 2 commits into
AKIB2005 wants to merge 2 commits into
Conversation
|
@AKIB2005 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @AKIB2005Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @AKIB2005!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user uploads a video file larger than 500MB, the app would silently
hang or crash the browser tab during export with no feedback. This PR adds
a visible, dismissible warning banner that appears immediately after a large
file is selected, informing the user of the risk before they attempt export.
Changes made:
VideoEditor.tsxwitha proper yellow alert banner triggered at 500MB
AlertTrianglefromlucide-react(already in project, zero new dependencies)Related Issue
Fixes #(Closes #1563)
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link: (record yourself uploading a 500MB+ file and showing the banner appears, then dismissing it)
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in