Skip to content

Add CSP nonce to NewRelic Scripts on frontend #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
del15881 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add CSP nonce to NewRelic Scripts on frontend #4620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/venia-concept/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
{{#newRelicHeader}}
<script nonce="{{pageTypeNonce}}">{{{newRelicHeader}}}</script>
{{/newRelicHeader}}
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="theme-color" content="#ff6334">
<link rel="manifest" href="/manifest.json">
Expand Down Expand Up @@ -195,6 +198,10 @@
<script type="text/javascript" src="/{{.}}"></script>
{{/webpackChunks}}
{{/pageTypeNonce}}
{{#newRelicFooter}}
<script nonce="{{pageTypeNonce}}">{{{newRelicFooter}}}</script>
{{/newRelicFooter}}
<!-- /Inlined Data -->

</body>
</html>
26 changes: 26 additions & 0 deletions packages/venia-ui/upward.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,26 @@ veniaWebpackChunks:
resolver: inline
inline: webpackChunks

# NewRelic header script
veniaNewRelicHeader:
resolver: inline
inline:
script:
resolver: computed
type:
resolver: inline
inline: newRelicHeader

# NewRelic footer script
veniaNewRelicFooter:
resolver: inline
inline:
script:
resolver: computed
type:
resolver: inline
inline: newRelicFooter

# The veniaAppShell object resolves to a response that returns server-side
# rendered HTML containing the PWA application shell.
# For SEO purposes, the appropriate meta tags in the HTML head element are also
Expand All @@ -172,6 +192,8 @@ veniaAppShell:
pageType: veniaPageType.data
pageTypeNonce: veniaPageTypeNonce.nonce
webpackChunks: veniaWebpackChunks.scripts
newRelicHeader: veniaNewRelicHeader.script
newRelicFooter: veniaNewRelicFooter.script
template:
resolver: file
file:
Expand Down Expand Up @@ -257,6 +279,8 @@ dynamicRedirect:
pageType: veniaPageType.data
pageTypeNonce: veniaPageTypeNonce.nonce
webpackChunks: veniaWebpackChunks.scripts
newRelicHeader: veniaNewRelicHeader.script
newRelicFooter: veniaNewRelicFooter.script
template:
resolver: file
file:
Expand All @@ -281,6 +305,8 @@ notFoundResponse:
pageType: veniaPageType.data
pageTypeNonce: veniaPageTypeNonce.nonce
webpackChunks: veniaWebpackChunks.scripts
newRelicHeader: veniaNewRelicHeader.script
newRelicFooter: veniaNewRelicFooter.script
template:
resolver: file
file:
Expand Down
Loading