fix: hardcoded ".html" URL suffix on Wishlist item product links - #4619
Open
Niki-Tester wants to merge 3 commits into
Open
fix: hardcoded ".html" URL suffix on Wishlist item product links#4619Niki-Tester wants to merge 3 commits into
Niki-Tester wants to merge 3 commits into
Conversation
Read product_url_suffix from storeConfig instead of appending a hardcoded ".html" string, so wishlist links respect the store's configured URL suffix.
Collaborator
LogERROR ON TASK: eslintCheck |
Collaborator
Collaborator
LogDetailsERROR ON TASK: lighthouseTests |
Collaborator
LogERROR ON TASK: cypressTests |
Niki-Tester
marked this pull request as draft
May 28, 2026 15:46
Niki-Tester
marked this pull request as ready for review
May 28, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wishlist item product links were built by concatenating url_key with a hardcoded .html suffix, ignoring the product_url_suffix value set in Magento's store configuration (Stores → Configuration → Catalog → Search Engine Optimization). On stores using a suffix other than .html (or no suffix), every wishlist item link resolved to a 404. The fix reads product_url_suffix from storeConfig and uses it when constructing the product URL, consistent with how product links are built elsewhere in the storefront.
Related Issue
Closes #4618
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
With the default .html suffix configured, verify that wishlist item links still resolve correctly to the product detail page.
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist