ci: add check-extension

[damienwebdev]

Adds the check-extension workflow for basic extension CI.

[damienwebdev]

Hello friends!

You can see failed builds here: https://github.com/damienwebdev/module-rma/actions/runs/28967191887

Looks like this doesn't support Magento v2.4.6 (I don't know if you have plans to). Let me know what versions you do intend to support and I can adjust the matrix.

https://github.com/damienwebdev/module-rma/actions/runs/28967191887/job/85953310083 seems to fail since you don't define a repository for this package in composer.json (I suspect it should be the mirror).

[marcelmtz]

Hello friends!

You can see failed builds here: https://github.com/damienwebdev/module-rma/actions/runs/28967191887

Looks like this doesn't support Magento v2.4.6 (I don't know if you have plans to). Let me know what versions you do intend to support and I can adjust the matrix.

https://github.com/damienwebdev/module-rma/actions/runs/28967191887/job/85953310083 seems to fail since you don't define a repository for this package in composer.json (I suspect it should be the mirror).

As this was included with MageOS 3 release, based on Magento 2.4.9 I think that should be from where we should support this. Created this PR #46
Ideally declaring the magento framework version should fix your failing tests right? (maybe I'm missing something else)

[rhoerr]

Okay, so -- the actual install error on 2.4.6 is that this module pins PHP version 8.3+. We should loosen that to 8.1 or 8.2+, and ensure the code is similarly compatible. That should take care of it. The specific Magento constraints aren't super important for this module.

  Problem 1
    - Root composer.json requires mage-os/module-rma @dev -> satisfiable by mage-os/module-rma[dev-main].
    - mage-os/module-rma dev-main requires php >=8.3 -> your php version (8.2.32) does not satisfy that requirement.

Error: Your requirements could not be resolved to an installable set of packages.

[SamueleMartini]

@rhoerr The module was developed on M2.4.8, made compatible with PHP 8.3, 8.4, and 8.5, and tested on M2.4.8 and 2.4.9.
I have never tested it with PHP 8.2, M2.4.6, or M2.4.7. Unfortunately, I haven't had time to look into it, so I don't know if lowering the PHP version specified in composer.json is enough.

[marcelmtz]

@rhoerr The module was developed on M2.4.8, made compatible with PHP 8.3, 8.4, and 8.5, and tested on M2.4.8 and 2.4.9. I have never tested it with PHP 8.2, M2.4.6, or M2.4.7. Unfortunately, I haven't had time to look into it, so I don't know if lowering the PHP version specified in composer.json is enough.

I've created this PR #47 to handle the Magento 2.4.6 support and php 8.2. Please take a look whenever its possible. Used the some similar composer requirements as you have on the tags module.

[rhoerr]

@damienwebdev Can you merge/sync latest main to your fork? Should resolve the 2.4.6 compatibility.

[damienwebdev]

@rhoerr rebased outcome is here: https://github.com/damienwebdev/module-rma/actions/runs/29876918168/job/88789406115

• coding-standard fails because the composer.json of mage-os/module-rma is missing the repository info.
• unit-test fails for a reason unclear to me.
• integration-test fails because there are no integration tests. This can be fixed by either creating an integration test or adding .github/check-extension.json to the repo with the contents:

{
  "$schema": "https://raw.githubusercontent.com/graycoreio/github-actions-magento2/main/resolve-check-config/check-extension.schema.json",
  "jobs": {
    "integration_test": false
  }
}