Add jvm_flags support to Twirl toolchain and update to new annex Scala toolchain#53
Open
jjudd wants to merge 1 commit into
Open
Add jvm_flags support to Twirl toolchain and update to new annex Scala toolchain#53jjudd wants to merge 1 commit into
jjudd wants to merge 1 commit into
Conversation
jjudd
changed the title
jjudd
force-pushed
the
jjudd-annex-toolchain-update
branch
from
73257ff to
b47313e
Compare
jadenPete
reviewed
Jun 16, 2026
| "scala_version_setting", | ||
| ) | ||
|
|
||
| def _twirl_toolchain_transition_impl(settings, attr): |
Contributor
There was a problem hiding this comment.
Why are we no longer managing the Twirl configuration in this transition? Also, can we reuse the transitions from rules_scala_annex instead of manually setting and resetting the Scala configuration?
Contributor
There was a problem hiding this comment.
Oh, is it because we've deleted the Twirl configuration settings in favor of having the Scala version completely determine the Twirl toolchain? If so, this looks good to me. But I still think it'd be favorable to reuse the transitions from rules_scala_annex.
| executable = True, | ||
| doc = "Tool used to compile Twirl templates", | ||
| ), | ||
| "jvm_flags": attr.string_list( |
Contributor
There was a problem hiding this comment.
Rather than making this an attribute on the Twirl toolchain, why don't we use the JVM arguments on the Scala toolchain?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.