Relax SIP outbound validation to support carriers.#1611
Merged
Conversation
🦋 Changeset detectedLatest commit: 0611ac2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hechen-eng
approved these changes
Jun 9, 2026
| if p.SipTrunkId == "" && p.Trunk == nil { | ||
| return errors.New("missing sip trunk id") | ||
| if p.SipTrunkId == "" && p.Trunk == nil && p.SipNumber == "" { | ||
| return errors.New("missing sip trunk id or sip number to use") |
Contributor
There was a problem hiding this comment.
missing sip trunk id and sip number?
Contributor
There was a problem hiding this comment.
@dennwc we also need to check that this is belonging to the account right ?
Contributor
Author
There was a problem hiding this comment.
This is a protocol package, it cannot make this decision here. It will be done in IO.
dennwc
force-pushed
the
sip-carrier-outbound
branch
from
265f874 to
0611ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.