Visibility controls on public API#121
Draft
alan-george-lk wants to merge 10 commits intomainfrom
Draft
Conversation
…truly_private_spdlog
…truly_private_spdlog
alan-george-lk
changed the title
| #include "audio_frame.h" | ||
| #include "local_track_publication.h" | ||
| #include "track.h" | ||
| #include "visibility.h" |
Collaborator
There was a problem hiding this comment.
some places i see:
#include "livekit/visibility.h" in other locations #include "visibility.h"
Collaborator
Author
There was a problem hiding this comment.
Good call, I think Opus added it like this to match convention already in the files. We should come up with a standard convention (using the livekit/ prefix or not) and commit to that. See how the ones above this line don't have the prefix, but this file does use them even though it's the same folder:
client-sdk-cpp/include/livekit/track.h
Line 26 in af0820c
Collaborator
There was a problem hiding this comment.
hm, this is probably AI run away, i think we should be using #include "livekit/*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
LIVEKIT_APImacro to expose LiveKit API symbols across platforms (common convention, example)spdlogwas installed at the system level in CI (and documented for users to install at that level), but was brought in viaFetchContent/vcpkg. This is no longer needed (system install). Removed that flow and deprecated the CMake argument/functionality for using system levelspdlog. It is now entirely within the SDK and fully private/no symbols exposed to clashTesting
spdlogclash with third-party lib)