Adds ability to scope or descope users from the filter#136
Draft
ryannewington wants to merge 2 commits into
Draft
Adds ability to scope or descope users from the filter#136ryannewington wants to merge 2 commits into
ryannewington wants to merge 2 commits into
Conversation
Added new test files `PasswordEvaluatorInScopeTests.cpp` and `RegistryTests.cpp` to the `NativeUnitTests.vcxproj` and `NativeUnitTests.vcxproj.filters` project files. Updated `filter.cpp` and `passwordevaluator.cpp` to include the `IsUserInScope` function, generating event log messages for excluded users. Enhanced `registry.cpp` to support multi-string registry values and log errors. Updated `messages.h`, `messages.mc`, `passwordevaluator.h`, and `registry.h` to declare new functions and constants. Modified `lithnet.activedirectory.passwordfilter.adml` and `lithnet.activedirectory.passwordfilter.admx` to add new policies. Updated `messages.res` to reflect message changes. Added necessary includes and implemented test methods in `PasswordEvaluatorInScopeTests` and `RegistryTests` to verify new functionalities.
…and PasswordFilterEx functions. Changed the return value from TRUE to PASSWORD_APPROVED for consistency and clarity.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new test files
PasswordEvaluatorInScopeTests.cppandRegistryTests.cppto theNativeUnitTests.vcxprojandNativeUnitTests.vcxproj.filtersproject files. Updatedfilter.cppandpasswordevaluator.cppto include theIsUserInScopefunction, generating event log messages for excluded users. Enhancedregistry.cppto support multi-string registry values and log errors. Updatedmessages.h,messages.mc,passwordevaluator.h, andregistry.hto declare new functions and constants. Modifiedlithnet.activedirectory.passwordfilter.admlandlithnet.activedirectory.passwordfilter.admxto add new policies. Updatedmessages.resto reflect message changes. Added necessary includes and implemented test methods inPasswordEvaluatorInScopeTestsandRegistryTeststo verify new functionalities.