Skip to content

test: remove unused files, py26 tests#878

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-unused
Jun 24, 2026
Merged

test: remove unused files, py26 tests#878
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-unused

Conversation

@richm

@richm richm commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

We do not use molecule.

The custom requirements are no longer needed.

Remove py26 requirements - the py26 python dependencies are too old now to maintain

Use ansible-core - much smaller than ansible

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • Chores
    • Updated Python test and coverage workflows to use the current coverage upload action and simplify the supported test matrix.
    • Cleaned up requirement files by removing outdated legacy version pins and obsolete entries.
    • Removed unused Molecule and related configuration content.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Removes Python 2.6 support from CI by deleting the python-26 workflow job and dropping py26 from the coverage script's tox environments. Updates the Codecov upload action to v6, replaces ansible with ansible-core in requirements files, removes old Python 2.x dependency pins, and clears legacy molecule and custom requirements content.

Changes

Python 2.6 removal and CI modernization

Layer / File(s) Summary
Drop py26 CI job and update Codecov action
.github/workflows/python-unit-test.yml
Removes the dedicated python-26 job (which ran tests via linux-system-roles/lsr-gh-action-py26) and updates the Codecov upload step to use codecov/codecov-action@v6.
Remove py26 from coverage collection script
tests/get_total_coverage.sh
The tox invocation for appending coverage data is changed to run only py27, py36, and py37, dropping py26.
Update requirements: ansible-core and remove legacy pins
pytest_extra_requirements.txt, ansible_pytest_extra_requirements.txt, molecule_extra_requirements.txt
Replaces ansible with ansible-core for python_version > "2.6", removes old idna and PyYAML version pins that guarded older Python versions, and clears the contents of molecule_extra_requirements.txt.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required Enhancement, Reason, Result, and Issue Tracker Tickets sections from the template. Reformat the PR description to include those four headings and fill in the missing details, including any Jira or BZ ticket.
Description Format ⚠️ Warning The PR description is plain prose and lacks the required Enhancement/Feature, Reason, and Result sections from .github/pull_request_template.md. Rewrite the PR description to use the template headings: Enhancement/Feature, Reason, Result, and optional Issue Tracker Tickets.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits and accurately summarizes the removal of unused test files and py26-related test coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@richm richm force-pushed the test-remove-unused branch from b8a7f4d to 5c74b9e Compare June 24, 2026 12:49
@richm richm changed the title test: remove unused files [citest_skip] test: remove unused files, py26 tests Jun 24, 2026
We do not use molecule.

The custom requirements are no longer needed.

Remove py26 requirements

Use ansible-core - much smaller than ansible

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the test-remove-unused branch from 5c74b9e to c377efb Compare June 24, 2026 12:51
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.19%. Comparing base (1b57520) to head (c377efb).
⚠️ Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   43.11%   43.19%   +0.07%     
==========================================
  Files          12       13       +1     
  Lines        3124     3172      +48     
==========================================
+ Hits         1347     1370      +23     
- Misses       1777     1802      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm richm merged commit 6be4f3e into linux-system-roles:main Jun 24, 2026
39 of 41 checks passed
@richm richm deleted the test-remove-unused branch June 24, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant