Skip to content

fix(file-picker): prevent duplicate selection counts#4094

Merged
doubleface merged 1 commit into
masterfrom
fix/pluralViAndRu
Jul 23, 2026
Merged

fix(file-picker): prevent duplicate selection counts#4094
doubleface merged 1 commit into
masterfrom
fix/pluralViAndRu

Conversation

@doubleface

@doubleface doubleface commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The file picker footer already prefixes the selected item count. Keep the Vietnamese and Russian translations count-free, while preserving the three Russian plural forms required by Polyglot.

Summary by CodeRabbit

  • Bug Fixes
    • Improved selected-item count wording in Russian and Vietnamese localization messages.
    • Updated pluralization text for clearer display across supported count variations.

The file picker footer already prefixes the selected item count. Keep the
Vietnamese and Russian translations count-free, while preserving the three
Russian plural forms required by Polyglot.
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 824f5dd7-a8e8-458c-b894-0bc6d0392c87

📥 Commits

Reviewing files that changed from the base of the PR and between 3341c53 and f4f8efc.

📒 Files selected for processing (2)
  • src/locales/ru.json
  • src/locales/vi.json

Walkthrough

Updated the SelectionBar.selected_count translations in Russian and Vietnamese. The Russian string now uses three pluralization cases. The Vietnamese string removes the explicit 1 singular wording and the %{smart_count} placeholder from the plural branch.

Suggested reviewers: lethemanh, rezk2ll, zatteo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing file-picker translations to avoid duplicate selection counts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pluralViAndRu

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
src/locales/ru.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

src/locales/vi.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@bundlemon

bundlemon Bot commented Jul 23, 2026

Copy link
Copy Markdown

BundleMon

Unchanged files (18)
Status Path Size Limits
static/js/(chunkId).(hash).js
767.23KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
275.6KB -
services/dacc.js
255.74KB -
static/js/main.(hash).js
56.94KB -
static/js/lib-react.(hash).js
43.88KB -
static/js/public.(hash).js
26.8KB -
static/js/lib-polyfill.(hash).js
22.76KB -
static/js/lib-router.(hash).js
21.92KB -
static/js/intents.(hash).js
17.24KB -
static/css/main.(hash).css
13.99KB -
static/js/async/(chunkId).(hash).js
7.5KB -
manifest.webapp
6.02KB -
static/css/public.(hash).css
2.71KB -
index.html
807B -
public/index.html
756B -
intents/index.html
680B -
assets/manifest.json
185B -

Total files change +2B 0%

Unchanged groups (3)
Status Path Size Limits
**/*.js
6.14MB -
**/*.{png,svg,ico}
2.16MB -
**/*.css
73.51KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@doubleface
doubleface merged commit 39baa74 into master Jul 23, 2026
6 checks passed
@doubleface
doubleface deleted the fix/pluralViAndRu branch July 23, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants