Skip to content

Fixes browser cache handling for generated msdf files #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uguraslan wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixes browser cache handling for generated msdf files #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions vite/msdfGenerator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,20 @@ export default function () {

if (fs.existsSync(generatedFontFile)) {
const fileContent = fs.readFileSync(generatedFontFile)
const etag = `"${generateHash(generatedFontFile)}"`

// Check if headers have already been sent
if (!res.headersSent) {
res.setHeader('Content-Type', mimeType)
res.setHeader('Cache-Control', 'public, max-age=31536000, immutable')
res.end(fileContent)
res.setHeader('Cache-Control', 'no-cache')
res.setHeader('ETag', etag)

if (req.headers['if-none-match'] === etag) {
res.statusCode = 304
res.end()
} else {
res.end(fileContent)
}
} else {
// this should never happen except some edge cases
console.error(`ERROR: Headers already sent for ${req.url}`, res.getHeaders())
Expand Down
Loading