docs: webrtc-direct-v2#715
Open
dozyio wants to merge 5 commits into
Open
Conversation
dozyio
commented
Apr 23, 2026
dozyio
commented
- Adds webrtc-direct-v2 spec
3 tasks
Author
|
Draft JS implementation libp2p/js-libp2p#3480 |
murat-dogan
pushed a commit
to murat-dogan/node-datachannel
that referenced
this pull request
Apr 26, 2026
Passes through `rtc::IceUdpMuxRequest::localUfrag` from libdatachannel to the JS `onUnhandledStunRequest` callback. Needed by the libp2p WebRTC-Direct v2 transport design (libp2p/specs#715). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tabcat
reviewed
May 27, 2026
Comment on lines
+189
to
+190
| 6. _B_ sets this inferred offer as remote description, generates an answer, and | ||
| sets it as local description. |
Member
There was a problem hiding this comment.
B's answer ice-ufrag/ice-pwd aren't specified here, but must be libp2p+webrtc+v2/<client_pwd> (the password A set for B in the synthetic answer) — otherwise the connection fails.
Comment on lines
+178
to
+180
| 4. _A_ starts sending STUN connectivity checks. _B_ parses STUN `USERNAME` as | ||
| `server_ufrag:client_ufrag` and validates that `server_ufrag` has the prefix | ||
| `libp2p+webrtc+v2/`. |
Member
There was a problem hiding this comment.
v1 has no equivalent prefix check, so a v1 server's handling of a v2/ ufrag is undefined. Each version should validate its prefix and drop on mismatch.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.