♻️ V6 missing parts - #104
Merged
Merged
Conversation
I don't think we'll need static callable as much as we did before. Thinking this over, I think this approach was a bit bloated but fine because we already paid for the callback object in other places. But a more compact and simple method would be to simply make a function for each ISR and use a global variable to point to the instance of driver that it belongs to. Thats basically what this is doing for us but with more complicated steps. Templates can be used to make this ergonomic if many ISRs need to be made, but the premise doesn't need to be more than simply a technique vs a library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.