Skip to content

Iwslt 2022 dialect - #656

Open
m-wiesner wants to merge 3 commits into
lhotse-speech:masterfrom
m-wiesner:iwslt_2022_dialect
Open

Iwslt 2022 dialect#656
m-wiesner wants to merge 3 commits into
lhotse-speech:masterfrom
m-wiesner:iwslt_2022_dialect

Conversation

@m-wiesner

Copy link
Copy Markdown
Contributor

Adds recipe for Tunisian Dialect data used in the iwslt2022 dialectal speech translation task.

except ImportError:
import pip

pip._internal.main(["install", "pyarabic"])

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart trick, but as a user I would be extremely surprised if importing Lhotse triggered a pip install command. Please handle missing optional dependencies in the same way as throughout the rest of the code, see e.g. here:

if is_module_available("speechcolab"):
from speechcolab.datasets.gigaspeech import GigaSpeech
else:
raise ImportError(
"To process the GigaSpeech corpus, please install optional dependency: pip install speechcolab"
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants