Iwslt 2022 dialect - #656
Open
m-wiesner wants to merge 3 commits into
Open
Conversation
pzelasko
reviewed
Apr 5, 2022
| except ImportError: | ||
| import pip | ||
|
|
||
| pip._internal.main(["install", "pyarabic"]) |
Collaborator
There was a problem hiding this comment.
Smart trick, but as a user I would be extremely surprised if importing Lhotse triggered a pip install command. Please handle missing optional dependencies in the same way as throughout the rest of the code, see e.g. here:
lhotse/lhotse/recipes/gigaspeech.py
Lines 38 to 43 in 933fb64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds recipe for Tunisian Dialect data used in the iwslt2022 dialectal speech translation task.