Revert "Add Location header to finalize response (#85)" - #509
Merged
Conversation
This reverts commit 9c3d91b.
aarongable
requested review from
a team and
beautifulentropy
and removed request for
a team
July 28, 2025 22:28
jsha
approved these changes
Jul 28, 2025
Contributor
Author
|
Tests are failing because eggsampler/acme assumes the Finalize response has a Location header :D |
Contributor
Author
|
eggsampler/acme#28 to update eggsampler; if/when that merges I'll update the version of eggsampler used by the pebble tests in this PR. |
jsha
approved these changes
Sep 8, 2025
jsha
left a comment
jsha
left a comment
Contributor
There was a problem hiding this comment.
Looks like no update here was needed after eggsampler/acme#28 was merged, because we run tests based on the latest eggsampler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9c3d91b, which was merged as a result of #85. That PR based on the idea that the Location header is required to be included with the Finalize response in RFC 8555, but this is not the case: it appears in the example response, but its inclusion there is not mandated by the text.
Although Boulder does provide the Location header in Finalize responses, there exist other ACME implementations which do not. Therefore it is useful for Pebble to omit it, so that clients developed against Pebble do not come to rely on its inclusion.
Fixes #508