Skip to content

fix(hermes): harden delegation router safety#188

Merged
saschabuehrle merged 1 commit into
mainfrom
fix/hermes-router-safety
May 16, 2026
Merged

fix(hermes): harden delegation router safety#188
saschabuehrle merged 1 commit into
mainfrom
fix/hermes-router-safety

Conversation

@saschabuehrle

Copy link
Copy Markdown
Collaborator

Summary

Hardens the new Hermes delegation router based on user-perspective integration testing across CascadeFlow and the Hermes PR branch.

Fixes two safety issues found during cross-repo smoke testing:

  • parent-level loaded_skills no longer participate in task-domain classification, so a parent with code/debugging skills does not accidentally route a legal/finance/medical child as code
  • high-stakes domains now require an explicit matching route and cannot fall back to simple, hard, or general complexity routes

Also keeps loaded_skills in fallback audit metadata and adds broader classifier/router/type edge coverage.

Validation

python -m pytest -o addopts='' tests/integrations/test_hermes_classifier.py tests/integrations/test_hermes_config.py tests/integrations/test_hermes_router.py tests/integrations/test_hermes_router_edges.py tests/integrations/test_hermes_skill_metadata.py tests/integrations/test_hermes_types.py -q
# 82 passed

python -m ruff check cascadeflow/integrations/hermes tests/integrations/test_hermes_classifier.py tests/integrations/test_hermes_config.py tests/integrations/test_hermes_router.py tests/integrations/test_hermes_router_edges.py tests/integrations/test_hermes_skill_metadata.py tests/integrations/test_hermes_types.py examples/integrations/hermes_delegation_router.py
# passed

python -m pytest -q -m 'not integration and not requires_api and not requires_ollama and not requires_vllm and not slow'
# 1290 passed, 40 skipped, 59 deselected

Additional manual checks:

  • cross-repo Hermes + local CascadeFlow smoke passed for route, observe, low confidence, provider-only, reasoning-only, and unconfigured legal fallback
  • wheel build via pip wheel --no-deps includes cascadeflow/integrations/hermes/*
  • importing the built wheel and routing a Hermes debugging task passed

@saschabuehrle
saschabuehrle force-pushed the fix/hermes-router-safety branch from b590df4 to 0632241 Compare May 16, 2026 20:56
@saschabuehrle
saschabuehrle merged commit aae65be into main May 16, 2026
20 of 28 checks passed
@saschabuehrle
saschabuehrle deleted the fix/hermes-router-safety branch May 16, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant