Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the ArrowDownwardIcon component and its local index file. The review feedback highlights that the new icon should be exported from the main icons entry point to be accessible to library consumers. Additionally, there is a discrepancy between the code implementation of a downward arrow and the PR description's reference to an upward arrow that needs to be resolved.
Signed-off-by: Aman Karn <amankarn2007@gmail.com>
27def31 to
918510a
Compare
Signed-off-by: Aman Karn <amankarn2007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ArrowDownwardIconto Sistent to reduce dependency on@mui/icons-materialand ensure design consistency acrossLayer5 products.
Changes
ArrowDownwardIconcomponent insrc/icons/ArrowDownward/src/icons/ArrowDownward/index.tsRelated Issue
Closes #1414
Screenshots
N/A (SVG Icon)