fix(ci): use --legacy-peer-deps when bumping meshery-extensions#1412
Merged
alexquincy merged 1 commit intomasterfrom Apr 17, 2026
Merged
fix(ci): use --legacy-peer-deps when bumping meshery-extensions#1412alexquincy merged 1 commit intomasterfrom
alexquincy merged 1 commit intomasterfrom
Conversation
The meshmap package legitimately relies on peer-dep relaxation (e.g. jquery@^4 × cytoscape-clipboard), matching its own install:legacy-peer-deps script. Without this flag the bump job fails with ERESOLVE on npm install, matching the bump-layer5 job which already uses --legacy-peer-deps. Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--legacy-peer-depstonpm installin thebump-meshery-extensionsjob ofnotify-dependents.yml, matching the existingbump-layer5job and meshmap's owninstall:legacy-peer-depsscript.Why
The previous run failed with ERESOLVE because
meshmap/has legitimate peer-dep relaxations (e.g.jquery@^4×cytoscape-clipboard): failing run. Paired with layer5labs/meshery-extensions#4193 which removes stale ESLint-9-pinning deps that were the primary blocker.Test plan
Bump Meshery, Meshery Extensions and Meshery Cloudmanually with latest release version and confirmbump-meshery-extensionssucceeds