Skip to content

[UI] Hide workspace actions for non-permitted users#1410

Merged
Rajesh-Nagarajan-11 merged 3 commits intolayer5io:masterfrom
Rajesh-Nagarajan-11:workspace-card-
Apr 17, 2026
Merged

[UI] Hide workspace actions for non-permitted users#1410
Rajesh-Nagarajan-11 merged 3 commits intolayer5io:masterfrom
Rajesh-Nagarajan-11:workspace-card-

Conversation

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

Notes for Reviewers

Implemented conditional rendering so that only users with the required permissions can view and perform actions

Output after connecting with local Sistent (current role: Org Admin)

Screencast.from.2026-01-07.15-24-10.webm

Output after connecting with local Sistent (current role: User)

Screencast.from.2026-01-07.15-28-33.webm

Signed commits

  • Yes, I signed my commits.

Rajesh-Nagarajan-11 and others added 2 commits April 15, 2026 09:32
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the WorkspaceCard component to conditionally render action icons and the bulk select checkbox based on permissions and selection state. Feedback indicates that the deleted property should be restored to the component arguments and used to disable the checkbox for soft-deleted workspaces, ensuring they cannot be selected for bulk actions.

Comment thread src/custom/Workspaces/WorkspaceCard.tsx
Comment thread src/custom/Workspaces/WorkspaceCard.tsx
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
@Junnygram
Copy link
Copy Markdown

LGTM

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me.

Copy link
Copy Markdown
Contributor

@banana-three-join banana-three-join left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rajesh-Nagarajan-11 , LGTM.

@KhushamBansal
Copy link
Copy Markdown
Member

LGTM!

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 merged commit 0a38c19 into layer5io:master Apr 17, 2026
5 checks passed
@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member Author

Thank you all for your reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants