-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(sistent): add Table component documentation #7610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sohamsig
wants to merge
5
commits into
layer5io:master
Choose a base branch
from
Sohamsig:sistent-table-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+387
−0
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
33e2ed4
feat(sistent): update table docs structure and add states
Sohamsig d74a725
feat(sistent): add guidance section for table
Sohamsig fcfaf46
fix: remove manual CodeBlock import
Sohamsig 829a997
Merge branch 'master' into sistent-table-docs
Rajesh-Nagarajan-11 04bdf39
docs: move codeblocks to code.mdx
Sohamsig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| --- | ||
| title: Table Code | ||
| component: table | ||
| description: Tables are used to organize and display structured data in rows and columns. | ||
| --- | ||
|
|
||
| import { | ||
| Table, | ||
| TableBody, | ||
| TableCell, | ||
| TableContainer, | ||
| TableHead, | ||
| TableRow | ||
| } from "@sistent/sistent" | ||
|
|
||
| Tables help display structured data in an organized and readable format. | ||
|
|
||
| <a id="Basic Table"> | ||
| <h2>Basic Table</h2> | ||
| </a> | ||
|
|
||
| Basic tables are used to display simple structured data. | ||
|
|
||
| <div className="showcase"> | ||
| <div className="items"> | ||
| <TableContainer> | ||
| <Table> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| <TableCell>Status</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| <TableCell>Active</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
| </div> | ||
| </div> | ||
|
|
||
| <a id="Striped Table"> | ||
| <h2>Striped Table</h2> | ||
| </a> | ||
|
|
||
| Striped tables improve readability by alternating row colors. | ||
|
|
||
| <div className="showcase"> | ||
| <div className="items"> | ||
| <TableContainer> | ||
| <Table striped> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
| </div> | ||
| </div> | ||
|
|
||
| <a id="Compact Table"> | ||
| <h2>Compact Table</h2> | ||
| </a> | ||
|
|
||
| Compact tables are useful when displaying dense data. | ||
|
|
||
| <div className="showcase"> | ||
| <div className="items"> | ||
| <TableContainer> | ||
| <Table size="small"> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| title: Table Guidance | ||
| component: table | ||
| description: Guidelines and best practices for using tables effectively. | ||
| --- | ||
|
|
||
| ## Function | ||
|
|
||
| Tables are used to organize structured data into rows and columns. They help users quickly scan, compare, and understand information. | ||
|
|
||
| Tables are useful for: | ||
|
|
||
| - Presenting structured data | ||
| - Comparing multiple values | ||
| - Displaying logs and metrics | ||
| - Listing users or resources | ||
|
|
||
| --- | ||
|
|
||
| ## Usage | ||
|
|
||
| Use tables when: | ||
|
|
||
| - Data must be compared | ||
| - Information is structured | ||
| - Users need quick scanning | ||
| - Displaying rows and columns | ||
|
|
||
| Avoid using tables when: | ||
|
|
||
| - Content is mostly text | ||
| - Layout is simple | ||
| - Data does not require comparison | ||
|
|
||
| --- | ||
|
|
||
| ## Best Practices | ||
|
|
||
| Follow these best practices when using tables: | ||
|
|
||
| - Use clear headers | ||
| - Avoid too many columns | ||
| - Keep rows readable | ||
| - Use pagination for large datasets | ||
| - Maintain consistent spacing | ||
|
|
||
| ### Use Clear Headers | ||
|
|
||
| Always include headers for better readability. | ||
|
|
||
| ```html | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>Name</th> | ||
| <th>Role</th> | ||
| </tr> | ||
| </thead> | ||
| </table> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| --- | ||
| name: "Table" | ||
| title: Table | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn’t right; we have more fields here. |
||
| published: true | ||
| component: table | ||
| description: A table is used to organize and display structured data in rows and columns. | ||
| --- | ||
|
|
||
| import { | ||
| Table, | ||
| TableBody, | ||
| TableCell, | ||
| TableContainer, | ||
| TableHead, | ||
| TableRow | ||
| } from "@sistent/sistent" | ||
|
|
||
| Tables are used to present structured data in a clear and organized way. They help users scan information quickly, compare values, and understand relationships between data. | ||
|
|
||
| ## Overview | ||
|
|
||
| Tables help organize data into rows and columns, making it easier to read and analyze information. | ||
|
|
||
| --- | ||
|
|
||
| ## Usage | ||
|
|
||
| Tables should be used when: | ||
|
|
||
| - Displaying structured data | ||
| - Comparing values | ||
| - Showing logs or metrics | ||
| - Listing users or resources | ||
|
|
||
| --- | ||
|
|
||
| ## Examples | ||
|
|
||
| ### Basic Table | ||
|
|
||
| Basic tables are used to display structured data in rows and columns. | ||
|
|
||
| <TableContainer> | ||
| <Table> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| <TableCell>Status</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| <TableCell>Active</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
|
|
||
| --- | ||
|
|
||
| ### Striped Table | ||
|
|
||
| Striped tables improve readability by alternating row colors. | ||
|
|
||
| <TableContainer> | ||
| <Table striped> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
|
|
||
| --- | ||
|
|
||
| ## States | ||
|
|
||
| ### Sortable Table | ||
|
|
||
| Tables can support sorting to help users organize data. | ||
|
|
||
| <TableContainer> | ||
| <Table> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
|
|
||
| --- | ||
|
|
||
| ### Selectable Rows | ||
|
|
||
| Tables can allow row selection. | ||
|
|
||
| <TableContainer> | ||
| <Table> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
|
|
||
| --- | ||
|
|
||
| ### Paginated Table | ||
|
|
||
| Tables can support pagination for large datasets. | ||
|
|
||
| <TableContainer> | ||
| <Table> | ||
| <TableHead> | ||
| <TableRow> | ||
| <TableCell>Name</TableCell> | ||
| <TableCell>Role</TableCell> | ||
| </TableRow> | ||
| </TableHead> | ||
| <TableBody> | ||
| <TableRow> | ||
| <TableCell>User 1</TableCell> | ||
| <TableCell>Contributor</TableCell> | ||
| </TableRow> | ||
| </TableBody> | ||
| </Table> | ||
| </TableContainer> | ||
|
|
||
| --- | ||
|
|
||
| ## Best Practices | ||
|
|
||
| - Use headers for clarity | ||
| - Avoid too many columns | ||
| - Keep rows readable | ||
| - Use pagination for large datasets | ||
| - Maintain consistent spacing | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the code ?